Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserted </span> at the end of the Inclusity roll #5612

Conversation

Autisticturtle3
Copy link
Member

Fixes #5373

What changes did you make?

  • Added missing tag at the end of the required roll

Why did you make the changes (we will use this info to test)?

  • The tag was missing.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Autisticturtle3-Refactor-HTML-Inclusivity-5373 gh-pages
git pull https://github.com/Autisticturtle3/website.git Refactor-HTML-Inclusivity-5373

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 27, 2023
@k-rewd k-rewd self-requested a review September 27, 2023 07:01
Copy link
Member

@k-rewd k-rewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Autisticturtle3 ! closing tag has been correctly added on the correct file per issue instructions. Just be sure to leave a note stating there are no applicable visual changes in place of the images on your pull request if there aren't any going forward. Thanks again!

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Autisticturtle3 Great job- your branches are correct, you are linked to the original issue, and your code edits are clean and only changing what needs to be changed. The description is good but could be more specific. For the next time, a good way to answer "Why did you make the changes...?" is to paraphrase the reason(s) given in the original issue. In this case, the reason could be: 'To resolve a linter error "Tag must be paired; missing " '.

Thanks for your work!

@t-will-gillis t-will-gillis merged commit 431cef8 into hackforla:gh-pages Oct 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML: _includes/about-page/about-card-platform.html - Inclusivity
3 participants