Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTML: _includes/about-page/about-card-platform.html - Agility #5370

Closed
4 tasks done
Tracked by #5279
roslynwythe opened this issue Aug 30, 2023 · 7 comments · Fixed by #5732
Closed
4 tasks done
Tracked by #5279

Refactor HTML: _includes/about-page/about-card-platform.html - Agility #5370

roslynwythe opened this issue Aug 30, 2023 · 7 comments · Fixed by #5732
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 30, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to update an HTML tag to resolve the linter error "Tag must be paired; missing </span>"

Action Items

  • In your local IDE, navigate to _includes/about-page/about-card-platform.html
  • Change the line of code
<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/agility.svg" alt=""></span><span class="sub-head-text color-deeppink">Agility</div>

to

<div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/agility.svg" alt=""></span><span class="sub-head-text color-deeppink">Agility</span></div>
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/about-page/about-card-platform.html
  2. Webpage(s): https://www.hackforla.org/about
  3. This issue is tracked in HfLA-Website: HTML linter audit spreadsheet, and Epic: Create Issues to Fix HTML linter errors #5279
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 30, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added good first issue Good for newcomers size: 0.25pt Can be done in 0.5 to 1.5 hours role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. Complexity: Missing size: missing labels Aug 30, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Aug 30, 2023
@Autisticturtle3 Autisticturtle3 self-assigned this Sep 27, 2023
@github-actions
Copy link

Hi @Autisticturtle3, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Autisticturtle3 Autisticturtle3 added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 27, 2023
@Autisticturtle3
Copy link
Member

Availability for this week: 10 hours
My estimated ETA for completing this issue: 1 hour
How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?: less than 1 hour
Provide Update

  1. Progress: finished
  2. Blockers: None
  3. Availability: 10 hours
  4. ETA: less than 1 hour

@Autisticturtle3 Autisticturtle3 removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 27, 2023
@roslynwythe
Copy link
Member Author

@Autisticturtle3 You are assigned to another issue #5373 which is not yet closed, so I am unassigning you from this issue. Please read our organization policies in the CONTRIBUTING document. It is not permissible to be assigned to more than one issue at a time. You will have to wait until PR #5612 is merged, which will closed issue #5373, before you can take on another issue.

@github-actions
Copy link

Hi @Sediqa-Fahimi, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@fahimicodes
Copy link
Member

fahimicodes commented Oct 17, 2023

Availability for this week: 8 hours
My estimated ETA for completing this issue: 2 hours

@fahimicodes
Copy link
Member

fahimicodes commented Oct 17, 2023

How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings? 3 hours.

Provide Update

  1. Progress: Completed and submitted PR for review.
  2. Blockers: None
  3. Availability: 8 hours.
  4. ETA: Less than 1 hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
4 participants