Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CfA sponsor #5409 #5522

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

ortegaa32
Copy link
Member

@ortegaa32 ortegaa32 commented Sep 13, 2023

Fixes #5409

What changes did you make?

  • Removed lines mentioning Code for America sponsorship from _includes/sponsors.html

Why did you make the changes (we will use this info to test)?

  • To reflect that CfA is no longer a sponsor of Hack for LA

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-09-13 at 2 19 57 PM
Visuals after changes are applied Screenshot 2023-09-13 at 2 20 11 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ortegaa32-remove-CfA-sponsor-5409 gh-pages
git pull https://github.com/ortegaa32/website.git remove-CfA-sponsor-5409

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: About Us https://www.hackforla.org/about/ time sensitive Needs to be worked on by a particular timeframe P-Feature: Home page https://www.hackforla.org/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 13, 2023
@ortegaa32 ortegaa32 changed the title Remove cf a sponsor 5409 Remove CfA sponsor #5409 Sep 13, 2023
@roslynwythe roslynwythe self-requested a review September 14, 2023 01:48
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ortegaa32 Great job on this issue. The branches are setup correctly, the code change is clean and correct, the PR is descriptive and it checks out perfectly in the browser. I apologize for the initial error in the issue and appreciate your patience and professionalism.

@one2code one2code self-requested a review September 14, 2023 02:41
Copy link
Member

@one2code one2code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes to the file have been successfully made, and when testing the latest changes in Docker, I noticed no breaking changes to the layout or CSS across all break points. Excellent job on resolving the issue.

@kwangric kwangric merged commit b472699 into hackforla:gh-pages Sep 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Home page https://www.hackforla.org/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove mention of CfA - sponsors on homepage
4 participants