Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove mention of CfA - sponsors on homepage #5409

Closed
3 tasks done
Tracked by #5403
roslynwythe opened this issue Sep 1, 2023 · 6 comments · Fixed by #5522
Closed
3 tasks done
Tracked by #5403

remove mention of CfA - sponsors on homepage #5409

roslynwythe opened this issue Sep 1, 2023 · 6 comments · Fixed by #5522
Assignees
@ortegaa32
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Home page https://www.hackforla.org/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Milestone
05. Know HFLA

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 1, 2023 •
edited by ortegaa32
Loading

Overview

We need to remove mention of CfA from the list of sponsors on the Hack for LA homepage.

  • In your local IDE, navigate to _includes/sponsors.html
  • remove these lines:
            <a href="https://www.codeforamerica.org" target="_blank" alt="Code for America">
                <img src="/assets/images/sponsors/code-for-america.svg" title="Code for America">
            </a>
  • Using Docker, view the webpages and confirm that "Code for America" has been removed from sponsors, and the rest of the page is unchanged.

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/sponsors.html
  2. Webpage(s): https://www.hackforla.org/
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 1, 2023
@github-actions

This comment was marked as resolved.

Sign in to view
@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Administrative Administrative chores etc. size: 0.5pt Can be done in 3 hours or less role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers and removed Complexity: Missing size: 0.5pt Can be done in 3 hours or less labels Sep 1, 2023
@roslynwythe roslynwythe mentioned this issue Sep 1, 2023
Closed
23 tasks
@roslynwythe roslynwythe added size: 0.25pt Can be done in 0.5 to 1.5 hours P-Feature: Home page https://www.hackforla.org/ time sensitive Needs to be worked on by a particular timeframe and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing labels Sep 3, 2023
@wanyuguan wanyuguan added this to the 05. Know HFLA milestone Sep 3, 2023
@pradeeptosarkar

This comment was marked as off-topic.

Sign in to view
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: About Us https://www.hackforla.org/about/ and removed Feature: Administrative Administrative chores etc. labels Sep 5, 2023
@ortegaa32 ortegaa32 self-assigned this Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hi @ortegaa32, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ortegaa32
Copy link
Member

Availability for this week: 1 - 3 PM everyday
My estimated ETA for completing this issue: 3 PM 09/07/23

@ortegaa32
Copy link
Member

Provide Update

  1. Progress: I removed the lines from the relevant file.
  2. Blockers: Despite removing the lines from the file, the CfA sponsor doesn't get removed from the webpages. I suspect that it may be due to the pages HTML files but I am not sure.
  3. Availability: 1-3PM everyday
  4. ETA: 09/13/23

@ortegaa32 ortegaa32 added the Status: Help Wanted Internal assistance is required to make progress label Sep 9, 2023
@roslynwythe
Copy link
Member Author

roslynwythe commented Sep 12, 2023 •
edited
Loading

Hi @ortegaa32 Are you previewing the changes locally? To do that, you must run docker-compose up and then browse to: http://localhost:4000/ and http://localhost:4000/about/#sponsors. Please contact me directly on Slack.

Also, after self-assigning an issue, please change the column to In Progress. I've done that for this issue. Thanks

@roslynwythe roslynwythe changed the title remove mention of CfA - sponsors remove mention of CfA - sponsors on homepage Sep 13, 2023
@roslynwythe roslynwythe removed the Status: Help Wanted Internal assistance is required to make progress label Sep 13, 2023
@ortegaa32 ortegaa32 mentioned this issue Sep 13, 2023
Merged
kwangric pushed a commit that referenced this issue Sep 15, 2023
@ortegaa32
Remove CfA sponsor #5409 (#5522)
b472699 
* Remove mention of CfA sponsor on homepage

* Remove mention of CfA sponsor on homepage

---------

Co-authored-by: Arturo Ortega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ortegaa32 ortegaa32

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Home page https://www.hackforla.org/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
05. Know HFLA
Development

Successfully merging a pull request may close this issue.

Remove CfA sponsor #5409 ortegaa32/website
5 participants
@roslynwythe @wanyuguan @ExperimentsInHonesty @pradeeptosarkar @ortegaa32