Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced single quotes with double quotes to avoid linter error #5335

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

ajb176
Copy link
Member

@ajb176 ajb176 commented Aug 29, 2023

Fixes #5281

What changes did you make?

-Replaced single quotes around class in HTML tag with double quotes

Why did you make the changes (we will use this info to test)?

-To avoid a linter error

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Minor formatting issue, no visual changes to website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ajb176-refactor-linter-5281 gh-pages
git pull https://github.com/ajb176/website.git refactor-linter-5281

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 29, 2023
@ajb176 ajb176 changed the title Replaced single quotes around class with double quotes Replaced single quotes with double quotes to avoid linter error Aug 29, 2023
@allison-truhlar allison-truhlar self-requested a review August 29, 2023 21:01
@allison-truhlar
Copy link
Member

Review ETA: EOD Tues
Availability: Tues 9-11pm ET

Copy link
Member

@allison-truhlar allison-truhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajb176! Great job with this pull request! The branches are set up correctly and there is a correctly formatted linked issue. You made only the requested change to the code and no visual changes resulted on the website, as expected. Keep up the good work!

@christinaor
Copy link
Member

I can see the change to double quotes, the branch name is descriptive, and branch itself is set up as it should be. Only thing is the formatting of the bullets in the issue is missing a space, so the dashes are appearing as themselves instead of bullets.

This is what you have:
" -some text"

vs. what it should be between the quotes to get the bullet points for next time:
" - some text"

Otherwise, great job @ajb176 !

@christinaor christinaor merged commit 4d7f8f2 into hackforla:gh-pages Aug 30, 2023
@ajb176 ajb176 deleted the refactor-linter-5281 branch October 10, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor HTML to resolve linter error: _includes/about-page/about-card-accomplishments.html
3 participants