Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTML to resolve linter error: _includes/about-page/about-card-accomplishments.html #5281

Closed
3 of 4 tasks
Tracked by #5279
roslynwythe opened this issue Aug 21, 2023 · 3 comments · Fixed by #5335
Closed
3 of 4 tasks
Tracked by #5279
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 21, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to update an HTML tag to resolve the linter error "Value of attribute [class] must be in double quotes"

Action Items

  • In your local IDE, navigate to _includes/about-page/about-card-accomplishments.html
  • Change the line of code
<div class='card-primary page-card-lg page-card--about'>

to

<div class="card-primary page-card-lg page-card--about">
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/about-page/about-card-accomplishments.html
  2. Webpage(s): https://www.hackforla.org/about
  3. This issue is tracked in HfLA-Website: HTML linter audit spreadsheet, and Epic: Create Issues to Fix HTML linter errors #5279
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 21, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours ready for product Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing ready for product labels Aug 21, 2023
@roslynwythe roslynwythe changed the title Refactor HTML to resolve linter error: _includes/about-page/about-card-executive-letter.html - div.card-primary Refactor HTML to resolve linter error: _includes/about-page/about-card-accomplishments.html - div.card-primary Aug 23, 2023
@wanyuguan wanyuguan added this to the x. Technical debt milestone Aug 26, 2023
@ajb176 ajb176 self-assigned this Aug 27, 2023
@github-actions
Copy link

Hi @ajb176, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ajb176
Copy link
Member

ajb176 commented Aug 27, 2023

i. 6am - 10am PST
ii. Tuesday EOD

@roslynwythe roslynwythe changed the title Refactor HTML to resolve linter error: _includes/about-page/about-card-accomplishments.html - div.card-primary Refactor HTML to resolve linter error: _includes/about-page/about-card-accomplishments.html Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

3 participants