Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5178 : Refactor img tag #5190

Closed
wants to merge 1 commit into from
Closed

Fix issue 5178 : Refactor img tag #5190

wants to merge 1 commit into from

Conversation

nitin-pandita
Copy link

@nitin-pandita nitin-pandita commented Aug 13, 2023

Fixes #5178

What changes did you make?

  • Deleted the backslash at the end of the image tag

Why did you make the changes (we will use this info to test)?

  • Change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@wongstephen wongstephen self-requested a review August 13, 2023 07:28
Copy link
Member

@wongstephen wongstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nitin-pandita

Great job with the 'good first issue'. The code that you pushed looks correct.

Your labels are not being pulled into the pull request. You likely need to add the issue # to the first line of the template "Fixes #replace_this_text_with_the_issue_number" so that the bot parses it correctly.

Next, you may want to add a brief description on why the changes were needed. A good way to do it for this issue is to paraphrase it directly from the issue: so that the codebase is consistent with how we use img HTML tags.

Your screenshots are not working for me. Screenshots are not necessary for this fix since there's not visual change, but if you choose to toss some in, that great too!

Great job! I also look forward to the changes.

@nitin-pandita
Copy link
Author

Hi @nitin-pandita

Great job with the 'good first issue'. The code that you pushed looks correct.

Your labels are not being pulled into the pull request. You likely need to add the issue # to the first line of the template "Fixes #replace_this_text_with_the_issue_number" so that the bot parses it correctly.

Next, you may want to add a brief description on why the changes were needed. A good way to do it for this issue is to paraphrase it directly from the issue: so that the codebase is consistent with how we use img HTML tags.

Your screenshots are not working for me. Screenshots are not necessary for this fix since there's not visual change, but if you choose to toss some in, that great too!

Great job! I also look forward to the changes.

I have done all the changes please have a look

@roslynwythe
Copy link
Member

@nitin-pandita I need to close this PR because the linked issue was not yet in the Prioritized Backlog column. Please message me on Slack if you need help finding another issue.

@nitin-pandita
Copy link
Author

@nitin-pandita I need to close this PR because the linked issue was not yet in the Prioritized Backlog column. Please message me on Slack if you need help finding another issue.

@roslynwythe thank you for your message, I would love to contribute, can you please tell me your slack username

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg2.svg
3 participants