-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg2.svg #5178
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@roslynwythe I am not sure how the inclusion of this For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/assets/js/current-projects.js helps me QA the change |
@ExperimentsInHonesty that was part of the template before I was assigned to the epic so I'm not sure I know exactly the reasoning behind it but I believe the idea is that you could browse to that file, search for the image filename specified in the issue title, and view the updated code. Please advise re: a better means of supporting QA. |
@roslynwythe wouldn't I just check the about page and that specific image?
|
Hi @aidanwsimmons, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
i. Availability: today untill 6pm, tuesday aftenoon-evening |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Monday, February 19, 2024 at 11:06 PM PST. |
Progress: issue seems to be resolved- ive verified my gh-pages branch is up to date, but im not seeing a back slack at the end of the tag as specified by the action item. |
As Aidan mentioned above, this problem seems to be already fixed:
|
Prerequisite
Overview
We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.
Action Items
_includes/about-page/about-card-sustainability.html
to
Resources/Instructions
The text was updated successfully, but these errors were encountered: