Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tools data for civic-tech-index.md #5114

Conversation

yujioshiro
Copy link
Member

Fixes #4800

What changes did you make?

  • Refactored the Tools data for civic-tech-index.md

Why did you make the changes (we will use this info to test)?

  • The filter menu for the project will include a filter called "Tools" and the refactor ensures the tools are are now individual strings inside a list instead of a single string

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

While there are no visual changes to the website, here is the before and after to show that the tools are rendered correctly for the viewer.

Visuals before changes are applied

Civic Tech

Visuals after changes are applied

Civic Tech

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b yujioshiro-refactor-tools-for-civic-tech-index-4800 gh-pages
git pull https://github.com/yujioshiro/hfla-website.git refactor-tools-for-civic-tech-index-4800

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly labels Jul 30, 2023
@DakuwoN
Copy link
Member

DakuwoN commented Jul 30, 2023

Review ETA: 6 PM 8/2/23
Availability: M-F 3PM - 9PM & Saturday Free

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @yujioshiro on this Pull Request. You setup the branches correctly, your code change is clean and correct, the tools data displays correctly in the browser on both the projects page and the civic tech index webpages, and you provided a description of the changes. Thank you for contributing to Hack for LA!

Copy link
Member

@DakuwoN DakuwoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @yujioshiro everything looks clean on this end! Keep up the great work!

@roslynwythe roslynwythe merged commit d7077e0 into hackforla:gh-pages Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Projects page https://www.hackforla.org/projects/ p-feature: Projects-check We use this page to check to make sure that teams are using the Technology section correctly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tools data for civic-tech-index.md
3 participants