-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Richard Kwang added to Website: Current Project Team #5058
Richard Kwang added to Website: Current Project Team #5058
Conversation
Availability: 7/25 noon - 2 pm |
Availability: 7/26 5:30-7PM PT |
Note to reviewers: git checkout -b update-add-rkwang-website-5038 gh-pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @k-rewd on your first good issue. Your setup the branches correctly, your code change is correct and clean and you have described your change and the purpose behind the change. Thank you for contributing to Hack for LA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job keeping the website updated, @k-rewd ! This looks good!
Hi @mademarc! If you still would like to review this request, please add your ETA and Availability when you get a minute. If not, please remove yourself as a reviewer. Thanks! |
Review ETA: 7/27/2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @k-rewd! I was going through pull requests to merge and noticed that there's a merge conflict on this issue now, as a result of #5052 (adding Ronald to the leadership list) being merged while this issue was getting reviewed. Can you pull the latest version of the Website project page and push the change with Richard added to the list back onto this branch? Everything else seems good (branching, issue, requested change made), so this merge conflict just needs to be resolved before I can merge your issue into the production branch! 😄 |
11d701f
Hello @adrianang ! Thank you for bringing this to my attention. Please confirm if the merge conflict with pr #5052 has be resolved correctly. I'll also send you a message on Slack in case I missed something. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k-rewd I just sent you a message on Slack, but there is an extra space at the start of line 81 that is giving me a YAML Exception reading error on Docker. When that extra space gets deleted, everything is working perfectly; can you delete that extra space and push another commit?
hi @adrianang! Sorry I missed that! Should be good to go now. I'll be more careful next time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k-rewd No worries! I just tested your branch for this issue on my local machine after you merged the updates to the website and everything on the Website project page is looking great and working great, with Richard added to the project team roster. Per my previous review, the branching is still set up well, the corresponding issue is linked, and the documentation is descriptive with provided screenshots. I'll merge this as the other aspects of your PR have been reviewed by others and only the merge conflict had to be resolved.
Thank you for taking up this issue and for also being patient and responsive with regards to the merge conflicts! 🙏🏼
Fixes #5038
What changes did you make?
leadership
variable by adding Richard Kwang's name, role, slack&github link and picture.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied