Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richard Kwang added to Website: Current Project Team #5058

Merged
merged 5 commits into from
Jul 30, 2023

Conversation

k-rewd
Copy link
Member

@k-rewd k-rewd commented Jul 24, 2023

Fixes #5038

What changes did you make?

  • Updated leadership variable by adding Richard Kwang's name, role, slack&github link and picture.

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

rkwang-before

Visuals after changes are applied

rkwang-after

@roslynwythe roslynwythe self-requested a review July 24, 2023 23:35
@roslynwythe
Copy link
Member

Availability: 7/25 noon - 2 pm
ETA: EOD 7/25

@Adastros Adastros requested review from mademarc and nnr-nnr July 26, 2023 02:16
@nnr-nnr
Copy link
Member

nnr-nnr commented Jul 26, 2023

Availability: 7/26 5:30-7PM PT
ETA: EOD 7/26

@roslynwythe
Copy link
Member

roslynwythe commented Jul 26, 2023

Note to reviewers:
Want to review this pull request? Take a look at this this documentation for a step by step guide!
From your project repository, check out a new branch and test the changes.

git checkout -b update-add-rkwang-website-5038 gh-pages
git pull https://github.com/k-rewd/website.git update-add-rkwang-website-5038

roslynwythe
roslynwythe previously approved these changes Jul 26, 2023
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @k-rewd on your first good issue. Your setup the branches correctly, your code change is correct and clean and you have described your change and the purpose behind the change. Thank you for contributing to Hack for LA.

@k-rewd k-rewd added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 26, 2023
@k-rewd k-rewd assigned k-rewd and unassigned k-rewd Jul 26, 2023
nnr-nnr
nnr-nnr previously approved these changes Jul 27, 2023
Copy link
Member

@nnr-nnr nnr-nnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job keeping the website updated, @k-rewd ! This looks good!

@LRenDO
Copy link
Member

LRenDO commented Jul 27, 2023

Hi @mademarc! If you still would like to review this request, please add your ETA and Availability when you get a minute. If not, please remove yourself as a reviewer. Thanks!

@roslynwythe roslynwythe added time sensitive Needs to be worked on by a particular timeframe and removed time sensitive Needs to be worked on by a particular timeframe labels Jul 28, 2023
@mademarc
Copy link
Member

Review ETA: 7/27/2023
Availability: 7:13PM

mademarc
mademarc previously approved these changes Jul 28, 2023
Copy link
Member

@mademarc mademarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @k-rewd Good job on adding the correct code for lines 75-80 and @LRenDO the ETA and Review is done.

@adrianang
Copy link
Member

Hi @k-rewd! I was going through pull requests to merge and noticed that there's a merge conflict on this issue now, as a result of #5052 (adding Ronald to the leadership list) being merged while this issue was getting reviewed. Can you pull the latest version of the Website project page and push the change with Richard added to the list back onto this branch?

Everything else seems good (branching, issue, requested change made), so this merge conflict just needs to be resolved before I can merge your issue into the production branch! 😄

@k-rewd k-rewd dismissed stale reviews from mademarc, nnr-nnr, and roslynwythe via 11d701f July 29, 2023 00:47
@k-rewd
Copy link
Member Author

k-rewd commented Jul 29, 2023

Hello @adrianang ! Thank you for bringing this to my attention. Please confirm if the merge conflict with pr #5052 has be resolved correctly. I'll also send you a message on Slack in case I missed something. Thank you!

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-rewd I just sent you a message on Slack, but there is an extra space at the start of line 81 that is giving me a YAML Exception reading error on Docker. When that extra space gets deleted, everything is working perfectly; can you delete that extra space and push another commit?

@k-rewd
Copy link
Member Author

k-rewd commented Jul 29, 2023

hi @adrianang! Sorry I missed that! Should be good to go now. I'll be more careful next time.

Copy link
Member

@adrianang adrianang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-rewd No worries! I just tested your branch for this issue on my local machine after you merged the updates to the website and everything on the Website project page is looking great and working great, with Richard added to the project team roster. Per my previous review, the branching is still set up well, the corresponding issue is linked, and the documentation is descriptive with provided screenshots. I'll merge this as the other aspects of your PR have been reviewed by others and only the merge conflict had to be resolved.

Thank you for taking up this issue and for also being patient and responsive with regards to the merge conflicts! 🙏🏼

@adrianang adrianang merged commit d8089f6 into hackforla:gh-pages Jul 30, 2023
awellsbiz pushed a commit to awellsbiz/website that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Add Richard Kwang to Website Team
6 participants