Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ronald Paek to Website Team #5052

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Added Ronald Paek to Website Team #5052

merged 1 commit into from
Jul 26, 2023

Conversation

ziniwang
Copy link
Member

Fixes #4919

What changes did you make?

  • I added the profile of Ronald Paek to the Website project page

Why did you make the changes (we will use this info to test)?

  • There is a new team member

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ziniwang-add-ronald-paek-to-profile-4919 gh-pages
git pull https://github.com/ziniwang/website.git add-ronald-paek-to-profile-4919

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 23, 2023
@roslynwythe roslynwythe requested review from mattmalane, DakuwoN and ronaldpaek and removed request for mattmalane July 23, 2023 17:06
@kwangric kwangric self-requested a review July 24, 2023 22:40
@kwangric
Copy link
Member

ETA: EOD 7/24
Availability: 3-7pm PDT

kwangric
kwangric approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The pull request includes the correct changes and everything looks good in Docker, including the links. Screenshots correctly show the visual changes. Great work on your first issue @ziniwang

ronaldpaek
ronaldpaek approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@ronaldpaek ronaldpaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Everything looks good to me; the image is loading just fine.

@kwangric
Copy link
Member

@DakuwoN When you get the chance, please add a comment with the ETA and availability for your review. Thanks!

@DakuwoN
Copy link
Member

DakuwoN commented Jul 25, 2023

EOD: 3/26 (Hopefully tomorrow)
Availability: 3-9PM EST

DakuwoN
DakuwoN approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@DakuwoN DakuwoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, done with perfection!

@kwangric kwangric merged commit eb06720 into hackforla:gh-pages Jul 26, 2023
@adrianang adrianang mentioned this pull request Jul 28, 2023
Merged
@DakuwoN DakuwoN mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldpaek ronaldpaek ronaldpaek approved these changes

@DakuwoN DakuwoN DakuwoN approved these changes

@kwangric kwangric kwangric approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Add Ronald Paek to Website Team
4 participants
@ziniwang @kwangric @DakuwoN @ronaldpaek