Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDG 13: Renamed and replaced image with correct color one #4516

Conversation

nicolettedmabeza
Copy link
Contributor

@nicolettedmabeza nicolettedmabeza commented Apr 14, 2023

Fixes #4257

What changes did you make and why did you make them ?

  • In the assets/images/sdg directory, deleted climate-action.svg
  • Downloaded E-WEB-Goal-13.svg from website drive and added it to assets/images/sdg directory.
  • Renamed svg to sdg13.svg
  • In _includes/about-page/about-card-sustainability.html, updated the path to the image
  • Replaced image so that the SDG 13 svg is the correct color and follows the UN SDG guidelines.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2023-04-14 at 11 44 20 AM
Visuals after changes are applied Screen Shot 2023-04-14 at 11 44 27 AM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nicolettedmabeza-sdg13-rename-and-replace-image-4257 gh-pages
git pull https://github.com/nicolettedmabeza/website.git sdg13-rename-and-replace-image-4257

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Apr 14, 2023
@kwangric kwangric self-requested a review April 14, 2023 21:16
@kwangric
Copy link
Member

ETA: EOD 5/15
Availability: After 1pm PDT 5/15

@drakenguyen4000 drakenguyen4000 self-requested a review April 15, 2023 04:31
@drakenguyen4000
Copy link
Member

ETA: 4/14/23
Availability: M-F 3:30pm-8pm

Copy link
Member

@drakenguyen4000 drakenguyen4000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @nicolettedmabeza. Your pull request is detailed, explains what changes and why, your PR is linked with the issue, and the PR is moved to Project Board. All changes met the issue criteria and the image displays correctly on different resolutions on Edge and Chrome.

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches were set up correctly and the requested changes were all made. Everything looks good in Docker, great work!

@roslynwythe roslynwythe merged commit e1ee8d7 into hackforla:gh-pages Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDG 13: Rename and replace image with correct color one
4 participants