Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDG 13: Rename and replace image with correct color one #4257

Closed
7 of 8 tasks
Tracked by #4153 ...
JessicaLucindaCheng opened this issue Mar 23, 2023 · 5 comments · Fixed by #4516
Closed
7 of 8 tasks
Tracked by #4153 ...

SDG 13: Rename and replace image with correct color one #4257

JessicaLucindaCheng opened this issue Mar 23, 2023 · 5 comments · Fixed by #4516
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 23, 2023

Dependency

Overview

We need to replace the Sustainable Development Goals (SDG) images in our repository so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines.

Details

SDG is an acronym for the United Nations Development Programme Sustainable Development Goals.

Action Items

  • In the assets/images/sdg directory, delete climate-action.svg
  • From the HackforLA.org website drive's HackforLA.org website/SDG/SDG images folder, download the following svg: E-WEB-Goal-13.svg
  • Add the svg you just downloaded into the assets/images/sdg directory
  • Rename that svg so that it becomes sdg13.svg
  • In _includes/about-page/about-card-sustainability.html, update the path to the image you just added by changing
<img src="/assets/images/sdg/climate-action.svg" alt="13 Climate Action" />

to

<img src="/assets/images/sdg/sdg13.svg" alt="13 Climate Action" />

Merge Team, Technical Lead, or Product Manager

  • Once the pull request associated with this issue is merged, go to each of the following issues and check if all the issues listed under the Dependency section are closed. If the dependencies are all closed, move those issues into the New Issue Approval column, remove the Dependency label on it, and add a ready for dev lead label to it.

Resources/Instructions

United Nations' SDG Information

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Mar 23, 2023
@JessicaLucindaCheng JessicaLucindaCheng added this to the 05. Know HFLA milestone Mar 23, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added Draft Issue is still in the process of being created and removed Draft Issue is still in the process of being created labels Mar 25, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title SDG 13: Replace image with correct color one SDG 13: Rename and replace image with correct color one Mar 26, 2023
@t-will-gillis t-will-gillis added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue labels Apr 3, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 5, 2023
@nicolettedmabeza nicolettedmabeza self-assigned this Apr 12, 2023
@github-actions
Copy link

Hi @nicolettedmabeza, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@nicolettedmabeza
Copy link
Contributor

Availability: 9a-5p M-F
ii. ETA: Friday 4/14 5pm

@nicolettedmabeza
Copy link
Contributor

Progress: Action items completed. Need to create pull request.
Blockers: None at this time.
Availability: 12p-5p M-F
ETA: 5pm today 4/14
Pictures (optional):
Before:
Screen Shot 2023-04-14 at 11 42 33 AM

After:
Screen Shot 2023-04-14 at 11 42 42 AM

@jdingeman
Copy link
Member

@nicolettedmabeza - please remember to place your issue into the In Progress column when you self assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants