-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: Fix size of SDG icons to match Figma design #4229
Comments
@JessicaLucindaCheng The dependencies have all been addressed. I gave a quick review and the icons and their backgrounds on the 311-data and lucky parking don't look right. So I reviewed the instructions and I don't think we have written up enough info about how to fix. Meaning I know there are specific files (css with the colors, SDG images, etc). But there is no information in this issue about where those files are. I am concerned the person working on this issue will start making new files, if they don't know where the existing files are. Has you made any wiki content for this? |
This comment was marked as resolved.
This comment was marked as resolved.
Action Items
|
@JessicaLucindaCheng it looks like there is a resizing issue for mobile too, here is a screenshot. I took this from my desktop, but it looks pretty much the same on my mobile phone |
I will review this epic by Wednesday, June 12, 2024. |
@JessicaLucindaCheng I had a chance to look at this issue and the pages It's related to. It seems like It's supposed to be covering the fact that the icons are smaller on the Figma and larger on the website page (see below), but the problem with changing it on the citizen engagement page, is that it would also have to be smaller on the project page which is not going to look good (and also might affect accessibility). So we propose closing this issue as unplanned. FigmaCitizen Engagement Page |
no need to change the sizes |
Dependency
Overview
We want to check the sections that use the Sustainable Development Goal (SDG) icons on the website look good in mobile, tablet, and desktop views so that we maintain a professional website.
Details
Action Items
Resources/Instructions
The text was updated successfully, but these errors were encountered: