Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Fix size of SDG icons to match Figma design #4229

Closed
7 of 12 tasks
JessicaLucindaCheng opened this issue Mar 22, 2023 · 7 comments
Closed
7 of 12 tasks

Epic: Fix size of SDG icons to match Figma design #4229

JessicaLucindaCheng opened this issue Mar 22, 2023 · 7 comments
Assignees
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Draft Issue is still in the process of being created epic Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: dev leads Tasks for technical leads size: 1pt Can be done in 4-6 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 22, 2023

Dependency

Overview

We want to check the sections that use the Sustainable Development Goal (SDG) icons on the website look good in mobile, tablet, and desktop views so that we maintain a professional website.

Details

Action Items

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Medium P-Feature: About Us https://www.hackforla.org/about/ Dependency An issue is blocking the completion or starting of another issue size: 1pt Can be done in 4-6 hours labels Mar 22, 2023
@JessicaLucindaCheng JessicaLucindaCheng added role: dev leads Tasks for technical leads P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed role: front end Tasks for front end developers Complexity: Medium labels Mar 22, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Mar 23, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title About page: Fix sizing of SDG icons to match Figma design Fix size of SDG icons to match Figma design Mar 23, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) label Mar 23, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label May 15, 2023
@ExperimentsInHonesty
Copy link
Member

@JessicaLucindaCheng The dependencies have all been addressed.

I gave a quick review and the icons and their backgrounds on the 311-data and lucky parking don't look right. So I reviewed the instructions and I don't think we have written up enough info about how to fix.

Meaning I know there are specific files (css with the colors, SDG images, etc). But there is no information in this issue about where those files are.

I am concerned the person working on this issue will start making new files, if they don't know where the existing files are.

Has you made any wiki content for this?

@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label May 15, 2023
@JessicaLucindaCheng JessicaLucindaCheng added the Issue Making: Level 2 Make issue(s) from an ER or Epic label May 15, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added the Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level label Oct 10, 2023
@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Jan 29, 2024

@JessicaLucindaCheng

Action Items

  • Write SDG wiki page, specifically for file locations, including css with the colors, SDG images, etc.
  • Add link to this issue
  • Make ready for prioritization

@JessicaLucindaCheng JessicaLucindaCheng changed the title Fix size of SDG icons to match Figma design ER: Fix size of SDG icons to match Figma design Jan 30, 2024
@JessicaLucindaCheng JessicaLucindaCheng added the ER Emergent Request label Jan 30, 2024
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER: Fix size of SDG icons to match Figma design Fix size of SDG icons to match Figma design Jan 30, 2024
@JessicaLucindaCheng JessicaLucindaCheng removed the ER Emergent Request label Jan 30, 2024
@roslynwythe roslynwythe changed the title Fix size of SDG icons to match Figma design Epic: Fix size of SDG icons to match Figma design Jan 30, 2024
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Feb 18, 2024

@JessicaLucindaCheng it looks like there is a resizing issue for mobile too, here is a screenshot. I took this from my desktop, but it looks pretty much the same on my mobile phone
https://www.hackforla.org/citizen-engagement

Details

image

@JessicaLucindaCheng JessicaLucindaCheng added ER Emergent Request and removed ER Emergent Request Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Feb 20, 2024
@JessicaLucindaCheng
Copy link
Member Author

I will review this epic by Wednesday, June 12, 2024.

@ExperimentsInHonesty
Copy link
Member

@JessicaLucindaCheng I had a chance to look at this issue and the pages It's related to. It seems like It's supposed to be covering the fact that the icons are smaller on the Figma and larger on the website page (see below), but the problem with changing it on the citizen engagement page, is that it would also have to be smaller on the project page which is not going to look good (and also might affect accessibility). So we propose closing this issue as unplanned.

Figma

figma: citizen engagement

Figma screenshot

Citizen Engagement Page

https://www.hackforla.org/citizen-engagement

live citizen engagement page

@ExperimentsInHonesty
Copy link
Member

no need to change the sizes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Draft Issue is still in the process of being created epic Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: About Us https://www.hackforla.org/about/ P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: dev leads Tasks for technical leads size: 1pt Can be done in 4-6 hours
Development

No branches or pull requests

2 participants