Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDG 2: Rename and replace image with correct color one #4254

Closed
7 of 8 tasks
Tracked by #4153
, #4183 ,  #4229
...
JessicaLucindaCheng opened this issue Mar 23, 2023 · 3 comments · Fixed by #4443
Closed
7 of 8 tasks
Tracked by #4153
, #4183 ,  #4229
...

SDG 2: Rename and replace image with correct color one #4254

JessicaLucindaCheng opened this issue Mar 23, 2023 · 3 comments · Fixed by #4443
Assignees
@cng008
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Milestone
05. Know HFLA

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 23, 2023 •
edited
Loading

Dependency

Overview

We need to replace the Sustainable Development Goals (SDG) images in our repository so that the SDG svgs are the correct color and follow the United Nations' SDG guidelines.

Details

SDG is an acronym for the United Nations Development Programme Sustainable Development Goals.

Action Items

  • In the assets/images/sdg directory, delete zero-hunger.svg
  • From the HackforLA.org website drive's HackforLA.org website/SDG/SDG images folder, download the following svg: E-WEB-Goal-02.svg
  • Add the svg you just downloaded into the assets/images/sdg directory
  • Rename that svg so that it becomes sdg2.svg
  • In _includes/about-page/about-card-sustainability.html, update the path to the image you just added by changing 
    <img src="/assets/images/sdg/zero-hunger.svg" alt="2 Zero Hunger" />
    to 
    <img src="/assets/images/sdg/sdg2.svg" alt="2 Zero Hunger" />
  • Using Docker, check the About page's Sustainability section (https://www.hackforla.org/about/#sustainability) to check that the SDG image shows up on the same spot as on the live webpage

Merge Team, Technical Lead, or Product Manager

  • Once the pull request associated with this issue is merged, go to each of the following issues and check if all the issues listed under the Dependency section are closed. If the dependencies are all closed, move those issues into the New Issue Approval column, remove the Dependency label on it, and add a ready for dev lead label to it.

Resources/Instructions

United Nations' SDG Information
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Mar 23, 2023
@JessicaLucindaCheng JessicaLucindaCheng added this to the 05. Know HFLA milestone Mar 23, 2023
This was referenced Mar 23, 2023
Closed
Closed
@JessicaLucindaCheng

This comment was marked as resolved.

Sign in to view
@JessicaLucindaCheng JessicaLucindaCheng mentioned this issue Mar 25, 2023
Open
38 tasks
@JessicaLucindaCheng JessicaLucindaCheng added Draft Issue is still in the process of being created and removed Draft Issue is still in the process of being created labels Mar 25, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title SDG 2: Replace image with correct color one SDG 2: Rename and replace image with correct color one Mar 25, 2023
@JessicaLucindaCheng JessicaLucindaCheng removed the Draft Issue is still in the process of being created label Mar 26, 2023
@t-will-gillis t-will-gillis added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue labels Apr 3, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 5, 2023
@cng008 cng008 self-assigned this Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

Hi @cng008, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@cng008
Copy link
Member

cng008 commented Apr 8, 2023

Availability: after 2pm most days
ETA: 4/8

@cng008 cng008 mentioned this issue Apr 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cng008 cng008

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
05. Know HFLA
Development

Successfully merging a pull request may close this issue.

SDG 2: Rename and replace image with correct color one cng008/website
4 participants
@JessicaLucindaCheng @ExperimentsInHonesty @t-will-gillis @cng008