-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action append top comment on Feature Branch #4496
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Updated: A job interview came up so I don't have the time on a weekday to dedicate to reviewing a large issue that I thought I would. I should still be able to tackle this weekend. Availability: Sat/Sun sporadically all day |
Availability: Weekdays this week after 5pm |
Reading through this, it looks like you are in need of help/suggestions rather than being done with this issue as the actions you are trying to create aren't working in your repo - is that correct? If so, perhaps a better way to get help is to close this PR and move your issue into the Questions/In Review column on the project board so Dev Leads can take a look or folks can look at it during a future meeting. Let me know if I'm reading this wrong and it really looks like you have done excellent work so far! |
@arcan9 I think marking the issue itself with the help wanted label and placing it in the Questions/In Review column like MJ mentioned would give it better visibility on the project board. That being said, it looks like you've got a good start at working out a complicated issue and I'd be interested in trying to help work out the bugs if you'd like. I sent you a message on Slack when you get a chance. |
@mjshelton12 @bootcamp-brian Hey, all! Due to personal life stuff, I've decided to close this PR and unassign myself from the issue altogether. I'll be on a break, but I truly appreciate your help. Best regards. |
PR is closed without merging. Moving to "IGNORE PRs closed without being merged" |
Fixes #1940
What changes did you make and why did you make them ?
/.github/workflows/issue-trigger.yml
./github-actions/trigger-issue/append-top-comment.js
) that contains the appended text and will only run if certain conditions are met (see the aformentionedyml
file).Testing in my own repo:
yml
andjs
filesFeature Branch
andFeature: Feature Branch
to see which one of these would trigger the jobI feel like I've done everything I could think of and I don't know what the problem is. Would appreciate help!
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.