Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update alt text for .project-card-mini-image images #4213

Merged
merged 1 commit into from
Mar 20, 2023
Merged

update alt text for .project-card-mini-image images #4213

merged 1 commit into from
Mar 20, 2023

Conversation

janice87
Copy link
Member

Fixes #3876

What changes did you make and why did you make them ?

  • Updated the img class="project-card-mini-image" alt text from alt="{{project.image_alt}}" to alt=""

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

program-areas-b4

Visuals after changes are applied

program-areas-after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b janice87-update-alt-text-3876 gh-pages
git pull https://github.com/janice87/website.git update-alt-text-3876

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Accessibility Issues that would broaden website accessibility size: 1pt Can be done in 4-6 hours labels Mar 19, 2023
@janice87
Copy link
Member Author

Availability for this week: Tuesday or Sunday
My estimated ETA for completing this issue: Tuesday 3/21/23

@mjshelton12 mjshelton12 self-requested a review March 20, 2023 00:24
@mjshelton12
Copy link
Member

Review ETA: Finish by EOD today
Availability: All of today

mjshelton12
mjshelton12 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mjshelton12 mjshelton12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on your first issue!

Your branches are done perfectly, the issue is properly attached, the changes can be seen when I pull them and are working correctly when I bring them up in docker, your code is clean, and I am adding my approval!

@Sebster3
Copy link
Member

Review ETA: Finished by EOD, 3/20
Availability: 2PM-5PM

Sebster3
Sebster3 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Sebster3 Sebster3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Janice! The requested changes are done cleanly, in the correct branch, and render properly in Docker. Approved!

@jdingeman jdingeman merged commit 9b0db8f into hackforla:gh-pages Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjshelton12 mjshelton12 mjshelton12 approved these changes

@Sebster3 Sebster3 Sebster3 approved these changes

Assignees
No one assigned
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Program Areas: Update alt text for .project-card-mini-image images to adhere to WCAG
4 participants
@janice87 @mjshelton12 @Sebster3 @jdingeman