Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TESTING, again, changes for gha 2592 #3897

Merged

Conversation

t-will-gillis
Copy link
Member

@t-will-gillis t-will-gillis commented Jan 30, 2023

Fixes #2592

What changes did you make and why did you make them ?

  • Continuation of first PR GHAs Remove Merged PRs from Project Board  #3846 , and PR TESTING final changes for testing gha 2592 #3867
  • Changed workflow run from previous on: pull_request to on: pull_request_target on line 3, also fixed minor grammatical error on line 9.
  • Justin D and I discussed last Thursday, Jan 26 after the last PR was merged and then reverted due to an error message: Parameter token or opts.auth is required at the 'Gather-Merged-PRs' action. The token & automation here is the same as for 'Move-Closed-Issues.' The latter automation is triggered by an 'issue' event and the automation runs successfully with read/write privileges, and the former is triggered by a 'pull-request' event and fails to run due to read only privileges. The GitHub Docs discuss differences in permissions between the different events esp. with forked, public repositories.
  • See below: the GitHub Docs suggest that the problem may be solved by renaming the event as noted above.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

GitHub Docs 1
GitHub Docs 2

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-TESTING-2-delete-merged-prs-2592 gh-pages
git pull https://github.com/t-will-gillis/website.git TESTING-2-delete-merged-prs-2592

@github-actions github-actions bot added automation for manulal github board maintenance actions that are going to be automated Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours Complexity: Medium Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe labels Jan 30, 2023
Copy link
Member

@jdingeman jdingeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about testing this GHA.

Merging this PR for testing - will revert if unsuccessful.

@jdingeman jdingeman merged commit 698795f into hackforla:gh-pages Feb 1, 2023
@jdingeman
Copy link
Member

Hey @t-will-gillis - you did a fantastic job. Looks like this PR was successfully removed from the project board. I watched it move to the top of test-approved-by-reviewer and prompty disappear off the column. See line above this comment showing that the HackforLABot removed the PR from the project board.

@jdingeman
Copy link
Member

Also checked that this PR didn't somehow override the actions set in the sort-closed-issues.js since the HackforLABot moved the linked issue immediately from QA to Done -- the linked issue has no hard labels related to the front end of the website so it shouldn't violate any rule in the .js file

image

@t-will-gillis t-will-gillis deleted the TESTING-2-delete-merged-prs-2592 branch February 1, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation for manulal github board maintenance actions that are going to be automated Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions: Remove merged PRs from the Project Board
2 participants