TESTING final changes for testing gha 2592 #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
automation
|
@hackforla/website-merge FYI |
jdingeman
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Dev demonstrated the workflow with his own copy of the Project Board. Advised to delete "branch: feature-homepage-launch" to prevent the removal of merged PRs for the homepage launch. Discussed that that can be another issue to automate homepage launch PRs.
Approving and merging this test PR.
- If successful, this issue will go into "test-approved-by-reviewer" column and be removed from the board while retaining the changes made. We will let this PR be the final commit to the code.
- If unsuccessful, this PR will be reverted and the issue reopened.
Workflow will not work for issues that have already been merged before this.
jdingeman
added a commit
that referenced
this pull request
Jan 27, 2023
This reverts commit 4bd6d74.
jdingeman
added a commit
that referenced
this pull request
Jan 27, 2023
|
PR was reverted for an error in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2592
What changes did you make and why did you make them ?
branch -'feature-homepage-launch'as decided in the initial reviewMove-PRtoGather-Merged-PRsto be more descriptive (fyi I tested on my side to make sure nothing broke)project: Project Boardrepo-token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }}@hackforla/website-merge
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied