Dropdown fix #3662
Dropdown fix #3662
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Refactor CSS
|
Review ETA: 10/25/22 @ 11pm |
|
ETA: 10/26/22 |
There was a problem hiding this comment.
Great work, @DmitriiTsy! The functionality of the dropdown filters menus seems to be preserved after your changes were made. I did want to mention a few things:
- On my code editor, I see the new file name with the file extension in lowercase (i.e.,
dropdown_filters.scssinstead ofdropdown_filters.SCSS). I don't know if that's what you're seeing on your end. @kathrynsilvaconway, does casing matter in this case? - I was wondering if the last action item in the issue was taken care of. I wasn't sure as I didn't see anything related to it in the comments.
- In the future, I would include the issue number in your branch name so we can identify the issue number at a glance.
- In the future, if there are no visual changes to the website, I would make a brief note that that's the case in the body of the PR.
I'm happy to approve once there's confirmation about that last action item!
|
ETA: End of Day 10/28/22 |
There was a problem hiding this comment.
Good work @DmitriiTsy ! 👍
It looks like you renamed _project-filter.scss and moved its location rather than creating a new file and deleting the old one as instructed in issue #3256. I agree with your approach as it removes the possibility of incorrectly copying the contents of _project-filter.scss into dropdown_filters.scss.
|
@giroz |
|
ETA: 10/29/22 |
There was a problem hiding this comment.
Hey @DmitriiTsy
Found the changes you made to the original file name - great and simple approach to this issue, it also passes the ABC's good job!
|
ETA: EOD 2022-10-30 |
There was a problem hiding this comment.
Hey @DmitriiTsy Thank you for working on this.
- Could you provide screenshot by running it locally? It is a requirement to test the site locally, and since this PR is related to CSS, I would look for if something isn't breaking the site.
- Could you provide demo to the merge team? It can be me for this as I am reviewing.
Let me know if you need help.
There was a problem hiding this comment.
Hi all,
When testing in your local environment, it is a good idea to docker-compose down and then docker-compose up after your changes are finished. Docker has a tendency to run an old image if it runs into an error if it's already running, and won't shut down.
For this issue, running on my local environment, running docker-compose up after switching into the branch caused it to exit because it cannot find the _project-filter.scss file, causing main.scss to import a nonexistent file.
In order for this to not break the page, you will need to import the newly created dropdown_filters scss file into main.scss.
Also, please note that, for naming conventions, the name of the filer should actually be _dropdown_filters.scss with the underscore in front.
|
Thank you so much @jdingeman. Now it works fine. |
|
ETA: 2022-11-12 |
|
Hi, sure. Here is Docker container Here is the website: Everything works fine for now. I can do a real-time demo with Zoom or send you a record - please let me know which is better |
Fixes #3256
What changes did you make and why did you make them?