Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create filter_dropdown.scss File in Elements Folder #3256

Closed
5 of 7 tasks
kathrynsilvaconway opened this issue Jun 16, 2022 · 14 comments · Fixed by #3887
Closed
5 of 7 tasks

Create filter_dropdown.scss File in Elements Folder #3256

kathrynsilvaconway opened this issue Jun 16, 2022 · 14 comments · Fixed by #3887
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@kathrynsilvaconway
Copy link
Member

kathrynsilvaconway commented Jun 16, 2022

Overview

Currently, the dropdown filters menus on the projects page and the toolkit page use different SCSS classes, which creates visual inconsistency for the user and also makes it hard for future developers to apply changes correctly. We need to create an SCSS file the will contain all the classes necessary to build our filter menus and store it in the elements folder for future use.

Action Items

  • create a new SCSS file in the elements folder called _dropdown_filters.SCSS.
  • Copy the entire contents of the _project-filter.scss file into the new _dropdown_filters.scss file.
  • Import the new scss file you created into main.scss and delete the import for the original _project-filter.scss
  • After you verify that the contents has been copied correctly, delete the original _project-filter.scss file in your local repo and test the site to make sure nothing is broken.
  • Push your code to your feature branch.
  • Demo your code with the merge team/tech leads. Which has not been made at this time. Check the bottom of this issue to see if an issue has been made yet. if not, leave a comment with this issue being done Design a fix the dropdown menu design for projects page #3277, if yes, then release dependency on the new issue that related this one.

Note to Merge Team/Tech Leads:

  • If moving this file does not break any code on the site, have the assignee open a pull request and the changes can be merged. If something does break, create an issue to investigate why and correct it.

Resources/Instructions

Here is the _project-filter.scss file:
https://github.com/hackforla/website/blob/gh-pages/_sass/components/_project-filter.scss

@kathrynsilvaconway kathrynsilvaconway added Complexity: Small Take this type of issues after the successful merge of your second good first issue Draft Issue is still in the process of being created labels Jun 16, 2022
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Jun 16, 2022
@github-actions
Copy link

Hi @kathrynsilvaconway.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@kathrynsilvaconway kathrynsilvaconway added role: front end Tasks for front end developers Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing Draft Issue is still in the process of being created labels Jun 21, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the Draft Issue is still in the process of being created label Sep 12, 2022
@kathrynsilvaconway kathrynsilvaconway added Ready for Prioritization and removed Draft Issue is still in the process of being created labels Sep 13, 2022
@ExperimentsInHonesty

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Sep 21, 2022
@kathrynsilvaconway kathrynsilvaconway added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 4, 2022
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Oct 9, 2022
@ExperimentsInHonesty

This comment was marked as resolved.

@blulady

This comment was marked as outdated.

@blulady blulady added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 24, 2022
@DmitriiTsy DmitriiTsy self-assigned this Oct 25, 2022
@github-actions

This comment was marked as outdated.

@DmitriiTsy

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@DmitriiTsy

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@DmitriiTsy

This comment was marked as outdated.

@arpitapandya

This comment was marked as outdated.

@github-actions
Copy link

Hi @wendybarrios, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@wendybarrios
Copy link
Contributor

wendybarrios commented Jan 11, 2023

i. Availability: Monday, Tuesday, Thursday : 8:00am - 12:30pm and 6:00 pm - 7:30pm
ii. ETA: Tuesday, 1/17

@wendybarrios
Copy link
Contributor

Blockers: School/Work
Availability: Evenings after 6:00pm
ETA: 1/27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
7 participants