Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dropdown menu for toolkit page #3985

Closed
4 tasks done
blulady opened this issue Feb 15, 2023 · 13 comments · Fixed by #4764
Closed
4 tasks done

Fix the dropdown menu for toolkit page #3985

blulady opened this issue Feb 15, 2023 · 13 comments · Fixed by #4764
Assignees
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours

Comments

@blulady
Copy link
Member

blulady commented Feb 15, 2023

Dependency

Overview

During recent audits, the team realized that the drop-down menu design is not uniform. In an attempt to unify all drop-down menus the design team has redesigned the drop-down menu. This issue is to implement the new uniform design specifically on the toolkit page using the component designed for the project page.

Action Items

  • Update the drop-down menu on the toolkit page to reflect the design in Figma using the component designed for the project page.
    • You do not need to develop the search bar function. The goal is to make this component reusable on multiple pages with different filters specified
  • Make the appropriate changes to the CSS, HTML, and JS as you need to
  • Ensure that changes to the component on the Toolkit page do not break pages in other pages (i.e. Projects Page, Wins, etc.)

Resources/Instructions

@blulady blulady added role: front end Tasks for front end developers Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ Dependency An issue is blocking the completion or starting of another issue Ready for Prioritization size: 3pt Can be done in 13-18 hours Draft Issue is still in the process of being created labels Feb 15, 2023
@ExperimentsInHonesty ExperimentsInHonesty removed Dependency An issue is blocking the completion or starting of another issue Complexity: Missing Draft Issue is still in the process of being created labels Feb 20, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Feb 20, 2023
@chrismenke45 chrismenke45 self-assigned this Feb 21, 2023
@github-actions

This comment was marked as outdated.

@chrismenke45

This comment was marked as outdated.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Feb 24, 2023
@chrismenke45

This comment was marked as outdated.

@chrismenke45

This comment was marked as outdated.

@chrismenke45

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Dependency An issue is blocking the completion or starting of another issue and removed Status: Updated No blockers and update is ready for review labels Mar 12, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Apr 13, 2023
@ExperimentsInHonesty

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng removed the Dependency An issue is blocking the completion or starting of another issue label Apr 17, 2023
@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 25, 2023
@kwangric kwangric self-assigned this Apr 30, 2023
@github-actions
Copy link

Hi @kwangric, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@kwangric
Copy link
Member

i. Availability: Weekdays after 1pm PDT
ii. ETA: May 12th

@kwangric
Copy link
Member

kwangric commented May 7, 2023

Progress: Haven't had as much time as I would have liked this past week, but I've removed the original dropdown menu and started reviewing the code for the new dropdown menu already implemented on the projects page.
Blockers: Having a little difficulty understanding the workflow of the code mentioned above. I'm slowly piecing it together and will try to contact Chris if I get completely stuck.
Availability: Most days I'm free after 3pm PDT
ETA: Still hoping to be completed by May 12th, will update if anything changes.

@kwangric
Copy link
Member

Progress: Been working through the issue this week, made progress populating the filters based on the guide-pages. Gonna be working on the filter functionality next.
Blockers: Having a little difficulty understanding the workflow of the code mentioned above. I'm slowly piecing it together and will try to contact Chris if I get completely stuck.
Availability: Most days I'm free after 5pm PDT
ETA: Gonna work on it through next week and hoping to get it done by Friday.
Pictures:
fil

@kwangric
Copy link
Member

Progress: Implemented the filter functionality. Just need to add additional features to make it uniform with the filters on the projects page. This includes:

  1. Adding a number in parenthesis indicating how many guides are in each filter.
  2. Adding buttons that show all applied filters, with the ability to clear the individual filters or all of them.
  3. Add 'view all' button in each category with more than 8 filters.
  4. Allow user to collapse each category.

Blockers: See comments below.

Availability: Most days I'm free after 3pm PDT

ETA: Within the next two weeks.


Details on blocker

As per the design on Figma, I've added all the filter categories for the guide pages except for "Technologies". Looking through the data for the guide-pages, there doesn't seem to be any information on technologies used. See pictures for details.


Design on Figma showing Technology section
  • Filters on the mockup on Figma show a Technology category with different technologies used.

Figma

Guide-Page in the repository without any technology information
  • The html file for the guide pages that I'm pulling the information to create the filters do not include technology.

Guide Page


Is there another location where the technology used can be found? If not, should I just exclude it? Thanks.

@ExperimentsInHonesty
Copy link
Member

Hi @kwangric. I think that the guides that are there now, are not great examples... However, you can add the following to the one you are using an an example.

Create a Kanban Project Board from Our Template
The Technology for it should be GitHub
the Tool name Kanban

Building a Survey Reporting Dashboard
Technology: Looker Studio
Tool: Dashboard

@kwangric
Copy link
Member

Progress: Finished most of the requirements of the issue. Last main issue is making it mobile friendly as well as some minor style details.
Blockers: N/A
Availability: Most days I'm free after 3pm PDT
ETA: On course to finish it this week

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours
Projects
Development

Successfully merging a pull request may close this issue.

6 participants