Fixes #2220 #3426
Fixes #2220 #3426
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
Feature: Refactor GHA
|
Availability: 6 Hours |
|
Availability: 5 Hours |
|
Where do we test it? Any specific tool? @BeckettOBrien @poorvi4 |
|
The Act from Nektos tool does look really helpful. Did you try it @BeckettOBrien? |
|
I did, but so far I only tested it on a different action because I'm still figuring out how to trigger specific scheduled actions or if I have to temporarily add a workflow_dispatch first. |
|
Hey @poorvi4 sorry, I am working on it, I am actually waiting on the GitHub action testing demo as discussed during our last team meeting as I am also having issues in testing. Once we figure that out I will review it. You may ask the team lead if you have to work on next issue since I holding this off for a while. |
|
Oh good catch! I updated the pull request so the add-update-label file should be correctly renamed to schedule-fri-0700 |
There was a problem hiding this comment.
When I run the action, I keep getting this error:
Unhandled error: Error: Cannot find module '../utils/find-linked-issue'
Require stack:
- /home/runner/work/website/website/github-actions/trigger-schedule/add-update-label-weekly/add-label.js
- /home/runner/work/_actions/actions/github-script/v4/dist/index.js
Have you experienced this error while running the action?
|
I think the problem is that line 302 is |
|
Hey @poorvi4, just wondering if you are still going to be able to finish this pull request. Please post an update or let us know if you won't be able to continue working on the PR. |
|
Hi sorry for the delay I’ll finish it up in the coming days |
There was a problem hiding this comment.
Hey @poorvi4,
Sorry it has taken me so long to get back to you, I've been wrestling with getting the project board locally. So I am currently running this test in my repo and I keep getting the error
`
Add-Update-Label-to-Issues-Weekly
Unhandled error: Error: Cannot find module '../utils/find-linked-issue'
Require stack:
- /home/runner/work/website/website/github-actions/trigger-schedule/add-update-label-weekly/add-label.js
- /home/runner/work/_actions/actions/github-script/v4/dist/index.js`
Which is odd because utils is in the same place it was relative to where the new file is.
Did you want to keep working on this or should we hand it off to someone else?
This comment was marked as outdated.
This comment was marked as outdated.
Fixes #2220
What changes did you make and why did you make them ?
Implemented solutions as suggested in #2220:
Much of the changes are purely for organizational purposes to better maintain the workflows/actions created
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No changes since the directories were reorganized and minor changes were made to accompanying files to better maintain code. Function remains same.
NOTE: One thing to mention is that I'm not entirely sure how to locally test a github action/workflow. If anyone knows, please let me know! I've found this tool neko which but I haven't used/tested it myself yet.