-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies action 2065 #3414
Update dependencies action 2065 #3414
Conversation
ETA: End of day 7/27 |
ETA: 7.24.22 |
ETA: 22-7-24 |
@blulady @kathrynsilvaconway FYI The intern who opened this PR- last day is Friday, so we need to respond to him in a timely way, so that he can fix anything that comes up before he goes. |
Hey Bonnie, so after you bailed on the Monday meeting we started talking about how I actually can't test this PR because when I wiped my repo and re-forked, I no longer had access to classic projects. I expected this PR to be closed the way we closed the other PR involving {{ secrets.PRIORITIZED_BACKLOG_COLUMN_ID }} and there is still yet another PR with this issue. Which is why I didn't unassign myself as a reviewer but I am happy to do it now. This issue is experiencing a similar problem. #3426 |
If it's too much of a hassle I can just put the column ID directly in the action and not use GitHub Secrets (I think the column id is publicly available information anyway). I just used a secret because I saw that other actions have used secrets for column ids in the past. Also, would we rather put the issue in the new issue approval or the prioritized backlog? I can think of benefits and tradeoffs for both, so just let me know which one you think would work best and I'll add the ID to the action. |
@BeckettOBrien please have it not use GitHub secrets if that information does not need to be secret. |
@blulady @hackforla/website-merge What do you want Beckett to do if he can't finish this issue before internship is over. Should we have someone take over the PR? |
c6c0378
to
f604e0e
Compare
That should be the only change that prevented the action from being deployed, and everything else (schedule, the contents of the issue posted, etc.) can be changed later and (hopefully) without needing my help.
|
#3598 Please see this issue for details as to why we are closing this issue. |
Fixes #2065
What changes did you make and why did you make them ?
.github/workflows/update-dependencies-issue.yml
github-actions/update-dependencies-issue/update-issue-template.md
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Created a new GitHub Actions workflow. No visual changes to the site.
Notes
There are a few things that might need to change before this PR can actually be merged: