-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented new mobile footer design 2554 #3183
Implemented new mobile footer design 2554 #3183
Conversation
…a/website into mobile-footer-redesign-2554
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: End of the day on 6/08 |
Availability: 2 hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Wny-Duong. Great job working on this issue! I can see that all of the currently live anchors work well, and all of the required links are shown. The mobile view looks just like the Figma mobile design. I also haven't spotted any issues so far, so I'll approve the pr. Awesome work!
Hi @Wny-Duong , sorry for the delay, I will have it reviewed by today (26th June) ETA : Sunday, June 26th |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! The footer has been added correctly to the "About Us", "Joins Us", "Toolkit" and "Get in Touch"!
I do not understand much about your change on sticky positioning but the original issue looks to be resolved.
Fixes #2554
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied