Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new mobile footer design 2554 #3183

Conversation

Wny-Duong
Copy link
Member

Fixes #2554

What changes did you make and why did you make them ?

  • Added four new text sections to the footer (under the donate button and above the link section), all of which are grouped into columns and contain links to various different parts of the website.
    • Some of these links are not functional since the anchors they're meant to link to haven't been made yet.
  • In the mobile footer, these columns will rearrange themselves to stack on top of each other in order to match the design shown in Figma on the original issue.
    • The design matches best only for 280 to 479 px in width. I think this was because the media rule used to distinguish between mobile and non-mobile in the rest of the _footer.scss file only encompasses width up to 479px. The pictures shown in visual changes are based on 425px width, smaller widths lead to longer links being separated in two lines if they use spaces.
  • Made adjustments to the main footer's css. The positioning of the footer now uses sticky positioning with a top margin that's also dependent on mobile versus non-mobile formatting.
    • Adding columns in the way I did caused the footer to cover content on the main body of the page when using absolute positioning with a 0 bottom margin. I think this is because the footer now has a dynamic height based on the sizes of the columns.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Wny-Duong-mobile-footer-redesign-2554 feature-homepage-launch
git pull https://github.com/Wny-Duong/website.git mobile-footer-redesign-2554

@github-actions github-actions bot added Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Footer role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Complexity: Medium Status: Updated No blockers and update is ready for review labels May 30, 2022
@Jaretzbalba Jaretzbalba self-requested a review May 30, 2022 17:38
@Jaretzbalba
Copy link
Member

Jaretzbalba commented May 30, 2022

ETA: End of the day on 6/08
Availability: 2 hours

@Carlos-A-P Carlos-A-P self-requested a review June 4, 2022 18:29
@Carlos-A-P
Copy link
Member

Carlos-A-P commented Jun 4, 2022

Availability: 2 hours
ETA: 6/06/2022

Copy link
Member

@Carlos-A-P Carlos-A-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Wny-Duong. Great job working on this issue! I can see that all of the currently live anchors work well, and all of the required links are shown. The mobile view looks just like the Figma mobile design. I also haven't spotted any issues so far, so I'll approve the pr. Awesome work!

@tamara-snyder tamara-snyder requested a review from usaboo June 19, 2022 17:22
@usaboo
Copy link
Member

usaboo commented Jun 26, 2022

Hi @Wny-Duong , sorry for the delay, I will have it reviewed by today (26th June)

ETA : Sunday, June 26th
Availability : 1 hour

@Wny-Duong Wny-Duong assigned Wny-Duong and unassigned Wny-Duong Jun 29, 2022
Copy link
Member

@usaboo usaboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! The footer has been added correctly to the "About Us", "Joins Us", "Toolkit" and "Get in Touch"!
I do not understand much about your change on sticky positioning but the original issue looks to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Footer role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging this pull request may close these issues.

5 participants