Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new design for the footer: mobile #2554

Closed
6 tasks done
R-Tomas-Gonzalez opened this issue Dec 7, 2021 · 10 comments
Closed
6 tasks done

Implement the new design for the footer: mobile #2554

R-Tomas-Gonzalez opened this issue Dec 7, 2021 · 10 comments
Assignees
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Footer role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@R-Tomas-Gonzalez
Copy link
Member

R-Tomas-Gonzalez commented Dec 7, 2021

### Dependency

Overview

We need to update the mobile view of the footer on the website to reflect the new design in Figma.

Details

We are changing the way the mobile footer looks. We will be adding sections to the footer that include: "Our Work", "Get in Touch", "Join Us", and "Toolkit.

Current Mobile Footer Screen Shot 2021-12-06 at 10 46 42 PM
Desired Mobile Footer Screen Shot 2021-12-06 at 10 36 11 PM

Note, the figma design in the desired mobile footer shows the last link on the bottom as "Privacy Policy". However, the current link on the website is "Join Us". The last link should remain as "Join Us".

Action Items

  • Feature Branch: You will be working off a feature branch called feature-homepage-launch and the pull request created from this issue should be pushed into that feature branch. Please read and follow the steps in the How to work off of a feature branch wiki article.
  • Navigate to footer.html -> /_includes/footer.html
  • Create new section under the Donate button, and above the link section
  • Include four sections of Our Work, Join Us, Get in Touch, Toolkit
  • Under each section add desired links according to figma design
  • If scss is necessary, add to the _footer.scss file -> /_sass/components/_footer.scss

Resources/Instructions

#2393 - issue for updating the footer design for desktop view
Figma - Mobile Footer Design

Issue Creator - Tomas Gonzalez
Designer of Feature - Stephen Parent

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

Hi @R-Tomas-Gonzalez.

Good job adding the required labels for this issue. The merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@macho-catt macho-catt added Dependency An issue is blocking the completion or starting of another issue Ready for Prioritization labels Dec 12, 2021
@ExperimentsInHonesty ExperimentsInHonesty added the Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages label Dec 13, 2021
@ExperimentsInHonesty
Copy link
Member

@R-Tomas-Gonzalez I added the feature branch label to this issue.

@ExperimentsInHonesty

This comment has been minimized.

@JimGeist

This comment has been minimized.

@R-Tomas-Gonzalez

This comment has been minimized.

@JimGeist JimGeist removed their assignment Dec 21, 2021
@ExperimentsInHonesty ExperimentsInHonesty changed the title Create new version of mobile footer Implement the new design for the footer: mobile Jan 16, 2022
@ExperimentsInHonesty

This comment has been minimized.

@JessicaLucindaCheng JessicaLucindaCheng removed the Dependency An issue is blocking the completion or starting of another issue label Feb 25, 2022
@JessicaLucindaCheng JessicaLucindaCheng added size: 2pt Can be done in 7-12 hours size: 1pt Can be done in 4-6 hours Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages and removed Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages size: 2pt Can be done in 7-12 hours labels Mar 8, 2022
@Wny-Duong Wny-Duong self-assigned this May 20, 2022
@Wny-Duong
Copy link
Member

Availability: (05/20-05/22): 6 hours, (05/25-05/29): 10 hours
ETA: Sunday, 5/29.

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented May 27, 2022

@Wny-Duong Here are the anchor links. These anchors may not all work since they may not all have been implemented yet. To check you can click on the links and see if they go to an anchor.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label May 27, 2022
@Wny-Duong
Copy link
Member

Update

  1. Progress: Mobile footer is roughly implemented with working links and placeholder links where anchors haven't been added yet. The current work done matches the Desired Mobile Footer layout for most mobile screen resolutions except for very small ones (less than 360px in width) as this causes the social media icons to become formatted strangely. There's also some inconsistencies with how much spacing exists between website content and footer because of a change I made to the main-footer styling in _footer.scss to prevent it from covering content at the very bottom.
  • Demonstration of issue with small mobile resolutions
    Demonstration of issue with small mobile resolutions
  • Demonstration of issue with spacing between website content and footer. The white blank space can be bigger or smaller depending on which the mobile resolution I'm testing with.
    image
  1. Blockers: None. Some slight tweaking needed with padding and margin values in _footer.scss should fix the issues mentioned in progress and I expect there won't be any serious issues.
  2. Availability: 5/28 - 5/29 (4 hours)
  3. ETA: Sunday, 5/29

@JessicaLucindaCheng
Copy link
Member

This issue has been completed with the merging of pull request #3183. However, there is an issue with the linking between this issue and that pr. (I even tried linking it manually but I was unable to.)

Thus, I'm closing this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages P-Feature: Footer role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

6 participants