-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed p- tags to h4-tags #3116
changed p- tags to h4-tags #3116
Conversation
@Olanrewaju-Ak Just wanted to let you know that I have removed the reviewers from your PR. Please do not add reviewers to your PR as we don't know if they are available. Generally, we assign reviewers during team meetings, or if someone is available, they can add themselves. Thank you. |
Not sure why labels aren't added but I will add them now so it is easy to see info about the pr quickly by looking at the labels. |
ETA: End of the day on 5/12 |
ETA: EoD Thursday, 12th May, 22 |
@Olanrewaju-Ak I noticed that this PR is being merged into the hackforla:2953-add-h-tags-to-getting-started-page-steps-4-5 branch. The correct branch is the hackforla:gh-pages branch. I would double check with the contributing.md to make sure you set up your local repository and remote upstream correctly. |
@Olanrewaju-Ak I noticed that you haven't followed the progression in which the issues should be worked on, i.e., good first issue, good second issue, small, medium, large. Also, as Jaret mentioned above the branches aren't correct. Therefore, would request you to close this PR, unassign from the corresponding issue and move it back to new issue approval column so it can be reprioritized. Then, please pick up your good first issue from the top of prioritized backlog column, you can use the following link which has filters applied to it: https://github.com/hackforla/website/projects/7?card_filter_query=label%3A%22role%3A+front+end%22+label%3A%22good+first+issue%22. Thanks. |
@SAUMILDHANKAR @Jaretzbalba thank you for the feedback. I’ll pick another first issue and be careful to follow the instructions. My Apologies |
Fixes #2953
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied