Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h tags to Getting Started page (Steps 4-5) #2953

Closed
5 tasks done
SAUMILDHANKAR opened this issue Mar 10, 2022 · 6 comments · Fixed by #3375
Closed
5 tasks done

Add h tags to Getting Started page (Steps 4-5) #2953

SAUMILDHANKAR opened this issue Mar 10, 2022 · 6 comments · Fixed by #3375
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Mar 10, 2022

Overview

As a developer, I need to replace p tags with h tags on the headings of Getting Started page (Steps 4-5) so it becomes WCAG compliant

Action Items

Resources/Instructions

@SAUMILDHANKAR SAUMILDHANKAR added role: front end Tasks for front end developers P-Feature: Getting Started https://www.hackforla.org/getting-started Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Mar 10, 2022
@github-actions

This comment was marked as resolved.

@SAUMILDHANKAR SAUMILDHANKAR changed the title Add h tags to Getting started page Add h tags to Getting Started page Mar 10, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title Add h tags to Getting Started page Add h tags to Getting Started page (Steps 4-5) Mar 11, 2022
@Olanrewaju-Ak Olanrewaju-Ak linked a pull request May 9, 2022 that will close this issue
@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label May 13, 2022
@SAUMILDHANKAR

This comment was marked as resolved.

@arpitapandya arpitapandya self-assigned this Jun 20, 2022
@arpitapandya
Copy link
Member

Availability for this week: 6hrs
My estimated ETA for completing this issue: 1.5hr

@arpitapandya
Copy link
Member

arpitapandya commented Jul 16, 2022

  • Time spent: 6hrs to complete
  • Availability: 6hrs for next week
  • Blockers: None for this issue

@arpitapandya
Copy link
Member

@JessicaLucindaCheng

  • Found a bug which can be a separate new issue to work on(or it's already in issues list) in Getting Started html,
  • At present Step 3 and Step 4 in Getting Started page isn't pointing to correct card.
  • changes required for the link Step 3 and Step 4
  • move line 27 and 28 to line 33 and 34
  • move line 33 and 34 to line 27 and 28
    getting-started-page-steps

@JessicaLucindaCheng
Copy link
Member

@arpitapandya
Thanks for bringing this up! It's already in the [issues spreadsheet] (https://docs.google.com/spreadsheets/d/1qEiDFUKPCVH3JNzGQSKl_HMl9vqNv8Z9gGrvw9MyYvU/edit#gid=772902542) as row #19. It actually should be the larger, detailed cards 3 and 4 should be switched so it matches the header order as per the Figma design.

Also, please leave your issue in the In Progress column. When your pull request is merged, there is automation that will close and move your issue to another column. I am going to go ahead and move this issue back to In Progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
5 participants