fixed spelling of non-profit to nonprofit, line 77, join-us.html

[JayBarbanel]

Fixes #2914

What changes did you make and why did you make them ?

• Changed text on line 77 in the join-us.html page from non-profit to nonprofit.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

![image](

)

Visuals after changes are applied

![image](

)

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b JayBarbanel-fix-misspelled-word-2914 gh-pages
git pull https://github.com/JayBarbanel/Hack-For-LA-Website.git fix-misspelled-word-2914

[Sparky-code]

Avail: 1hr
ETA: 4/22 EOD

[tamara-snyder]

Availability: 1 hour
Review ETA: 04/21/2022

[tamara-snyder]

Hi @JayBarbanel, great work! I'm just requesting you to change line 77 from "NonProfit" to "Nonprofit" to match what is written in the issue description, and also to post screenshots of your visual changes in your PR. Thank you!

[Sparky-code]

Hey @JayBarbanel, welcome to H4LA!
Your changes to join-us.html look good 👍
Since the issue is looking specifically at spelling and capitalization:

• The changes made doesn't read as accurate

• Your before image doesn't seem to show the correct 'prior' state from looking at your file change.

• I'm curious why there are changes to the docker-compose.yml file as well (I know there were some issue with docker for new volunteers, wondering if its related to that)

[JayBarbanel]

@Sparky-code weird - on my end it looks like it's updated and correct.
As for the image - I had pushed my first commit and then added the images after, so it only shows the version I had updated, not how the file was originally. I had to go back and just fix the cap on the 'P' in Nonprofit.
Next time I know to screenshot before doing any updating.

As for the .yml file - I was having issues but was advised to update that file, worked once I did.

Let me know how to move forward here, thank you!

[Sparky-code]

@JayBarbanel Sorry, bad phrasing. In your initial comment. Referencing the changes made.

What changes did you make and why did you make them ?
Changed text on line 77 in the join-us.html page from Non-Profit to Nonprofit.

No worries on the images, just wanted to note it. Same with the capitalization. just wanted to note it. If you can fix that text in the initial comment though. If you've addressed Tamara's request you should be able to 'request re-review' (the little recycle for her request and that should kick all the automated tests to complete and be ready for merge.

Gotcha on the .yml file 👍 glad that's working for you with an easy fix.

[JayBarbanel]

@Sparky-code Should be all good now! Thanks for walking me through that, I appreciate the help.

[Sparky-code]

@JayBarbanel Of course, we're all learning new stuff. Don't forget to re-request those reviews!
I'm going to check with the merge team about committing those changes to the .yml file, since that feels like it should be a separate issue.

[JessicaLucindaCheng]

@JayBarbanel Thanks for working on this issue! In addition to my in-line change requests, do the following:

• Please check off the items you have completed in your issue Fix misspelled word on join-us.html file from "non-profit" to "nonprofit" #2914

• Please add your pr to the Project Board.

  Click here for more detailed instructions on how to add your pr to the Project Board

  1. On the right, under the "Projects" section
     

  2. Click on the gear icon
     

  3. Then click on Project Board to add your pull request to the project board.
     

Also, in the future, you can take screenshots from the current, live website (https://www.hackforla.org/) for your before pictures instead of having to undo your changes to take the before screenshots.

[kathrynsilvaconway]

Availability: 1 hour
Review ETA: 04/27/2022

[kathrynsilvaconway]

@JayBarbanel Nice work fixing this error. I see you have made the requested change on line 77. Everything looks good in the html and I can see the changes locally. Good first issue!

[JayBarbanel]

@JessicaLucindaCheng Added this to the project board. As far as checking off what I've done in the issue..Where do I do that? I made a comment in the initial issue showing that I changed line 77, is there somewhere else I need to do that?

I think i should be all set, but I'm still seeing 3 change requests. Could you let me know if/what else I need to do to wrap this one up? Thank you!

[JessicaLucindaCheng]

• Availability: 2 hours
• Review ETA: Thu, Apr 28

[Sparky-code]

@JayBarbanel if you click through to the original issue you assigned yourself to (#2914), you'll find the 'Action Items' that you completed to create this PR. Check those off there.

Action Item Not completed

Action Item completed

[Sparky-code]

Hey Jay,

• Looks good!
• Thanks for addressing the detailed changes!

[JessicaLucindaCheng]

@JayBarbanel Thanks for making the changes. The code looks good to me now.

As far as checking off what I've done in the issue..Where do I do that?

See @Sparky-code's comment above about how to do that: #3076 (comment)
Please make sure to do that for any issues you work on.

Requested changes have been addressed.