Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Misspelled Word on Join Us Page #3072

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fixes Misspelled Word on Join Us Page #3072

merged 1 commit into from
Apr 22, 2022

Conversation

trishajjohnson
Copy link
Member

Fixes #2913

What changes did you make and why did you make them ?

  • Changes spelling of word community on line 93 from "commmunity" to "community"
  • Double checked to see that everything looked right and worked on web and mobile view.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screen Shot 2022-04-20 at 4 36 03 PM
Visuals after changes are applied Screen Shot 2022-04-20 at 4 37 10 PM

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b trishajjohnson-fix-misspelled-word-join-us-2913 gh-pages
git pull https://github.com/trishajjohnson/hfla_website.git fix-misspelled-word-join-us-2913

@github-actions github-actions bot added good first issue Good for newcomers P-Feature: Join Page https://www.hackforla.org/join role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less labels Apr 20, 2022
@Carlos-A-P Carlos-A-P self-requested a review April 21, 2022 04:14
@Carlos-A-P
Copy link
Member

Availability: 1 hr
ETA: 4/20/22 EOD

Carlos-A-P
Carlos-A-P approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@Carlos-A-P Carlos-A-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trishajjohnson Great job working on this issue! I can see the code changes in the join-us.html file and everything looks good in my localhost, both on mobile and desktop view.

@tamara-snyder tamara-snyder self-requested a review April 22, 2022 02:02
@tamara-snyder
Copy link
Member

Availability: 1 hour
Review ETA: 04/21/2022

tamara-snyder
tamara-snyder approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@tamara-snyder tamara-snyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trishajjohnson, great work on this! I love how you highlighted the changed word in your screenshots — super clear. Thank you!

@tamara-snyder tamara-snyder merged commit ce70eca into hackforla:gh-pages Apr 22, 2022
JessicaLucindaCheng added a commit to JessicaLucindaCheng/website that referenced this pull request May 13, 2022
@JessicaLucindaCheng @HackforLABot
@SAUMILDHANKAR @poorvi4 @ExperimentsInHonesty @Wny-Duong @gardenqu @sacamp @trishajjohnson @eodero @Sparky-code @matt-arofin @JayBarbanel @Jaretzbalba
Sm 1 feature homepage launch (#18)
9c91a2a 
* Update meeting data

* Update meeting data

* Update contributor and language data

* Added few points to issue progression action item

Added few points to issue progression action item

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update add labels trigger hackforla#2939 (hackforla#3042)

* Update add-labels-template.md

* Update add-labels-template.md

Rearranged original note

* Update open-community-survey.md

* Updated pre-work developer template

* Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062)

* Update meeting data

* Update contributor and language data

* fixed the spelling of sustainability (hackforla#3067)

* Update pre-work dev issue template

* Update meeting data

* Update contributor and language data

* Update issue templates

Added Wiki: Research Plan Review:  [REPLACE WITH NAME OF PAGE]

* Updated Project Profile Card review and update issue template

* Update issue templates

updated designer time

* Updated Credits file template: Edit content field and remove type field

* Updated Credits file template: Edit content field and remove type field

* Update meeting data

* Update contributor and language data

* Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072)

* Update meeting data

* Update contributor and language data

* Added feature-tech-dropdown branch

* Update meeting data

* Added feature-tech-dropdown branch

* Added feature-tech-dropdown branch

* Update contributor and language data

* changed the spelling from webapp to web app on line 56 (hackforla#3073)

* Update meeting data

* Update contributor and language data

* Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078)

This reverts commit f6deeff.

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079)

* Delete unused project-filter.js file (hackforla#3081)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076)

* fixed spelling of non-profit to nonprofit, line 77, join-us.html

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Add so go survey credit page 3022 (hackforla#3043)

* add new headers and tools section to credit page

* updated to empty alt tags for tools section

* fix snytax errors

* fix spacing in code and website page

* Fix indentation and add functionality for additional teams in "By:" field

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edited items on how to pick up your first issue.

Edited items on how to pick up your first issue.

* Create new Privacy Policy page and its credit, and edit label (hackforla#3083)

* Added privacy-policy.jpg

* Add privacy-policy.yml to credits

* Added initial privacy-policy scss and html files

* Added header and overview section

* Redoing the html page from scratch

* Added a line in main.scss to import privacy-policy.scss

* Added header section

* Added the content for section Visiting HackforLA.org

* Added content for section Email Addresses

* Added content for Google Analytics section

* Added content up through and including Third party service providers section

* Finished adding all the content in the HTML file

* Moved the import of privacy-policy.scss to the bottom of the components section

Reason is it didn't make sense that I just put it in the middle on the components section without any reason.

* Added styling for desktop version of page

* Added mobile styling and finished desktop styling

* Updated privacy-policy.yml credit

* Fixed styling

* Fixed styling

* Added spacing before the address on the bottom of the page

* Clarified "Project Profile Card review and update" template

* Update meeting data

* Update contributor and language data

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Saumil Dhankar <[email protected]>
Co-authored-by: Poorvi Rao <[email protected]>
Co-authored-by: Bonnie Wolfe <[email protected]>
Co-authored-by: Wilny Duong <[email protected]>
Co-authored-by: gardenqu <[email protected]>
Co-authored-by: Simone Campbell <[email protected]>
Co-authored-by: Trisha Johnson <[email protected]>
Co-authored-by: Erick Odero <[email protected]>
Co-authored-by: Devin Krizwold <[email protected]>
Co-authored-by: Matthew Arofin <[email protected]>
Co-authored-by: Jay Barbanel <[email protected]>
Co-authored-by: Jaret Balba <[email protected]>
JessicaLucindaCheng added a commit to JessicaLucindaCheng/website that referenced this pull request May 13, 2022
@JessicaLucindaCheng @arghmatey
@HackforLABot @SAUMILDHANKAR @poorvi4 @ExperimentsInHonesty @Wny-Duong @gardenqu @sacamp @trishajjohnson @eodero @Sparky-code @matt-arofin @JayBarbanel @Jaretzbalba
Sm 2 feature homepage launch (#19)
9f719e4 
* Homepage redesign (hackforla#2373)

* Adds communities of practice icons

* Adds COP icons to credits

* Links icons to CoP yml

* Update nav link

* Add communities icons for home page

* create new contact use section

* create new hero section of home page

* create home page communities section

* create home page join us section

* create mvp for home page program areas

* Adds anchor for home page links

* adds new home page technology section

* create home page wins section with wins card

* restyles home age for redesign

* Update program areas images

* Add border radius to containers

* Update padding on embrace section

* Hero mobile design

* Remove join text on mobile view

* Fix join text on tablet-up

* Remove contact text on mobiel view

* Develop mobile technologies section'

* Fix header padding

* Update hero CoP icons credits links

* Update hero CoP icons credits links

* Communities section mobile version

* Create small button element

* Final communities section gradient fix

* Random homepage win logic:

* Hide horizontal sidebars to match design

* Reposition homepage win overlay

* Resolve filename typo

* Change dataKey to match JSON variable

* Reposition home join us header

* Update photo for Civic Tech Infrastructure

* Use new _wins-data

* Update image link to use absolute_url variable

* Add homepage program areas links

* Refactor home wins js for _wins-data

* Disable link leading to about page

* Fix broken link path

* Remove about page link from main nav

* Move nav button styling to appropriate selector

* Sm 1 feature homepage launch (#18)

* Update meeting data

* Update meeting data

* Update contributor and language data

* Added few points to issue progression action item

Added few points to issue progression action item

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update add labels trigger hackforla#2939 (hackforla#3042)

* Update add-labels-template.md

* Update add-labels-template.md

Rearranged original note

* Update open-community-survey.md

* Updated pre-work developer template

* Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062)

* Update meeting data

* Update contributor and language data

* fixed the spelling of sustainability (hackforla#3067)

* Update pre-work dev issue template

* Update meeting data

* Update contributor and language data

* Update issue templates

Added Wiki: Research Plan Review:  [REPLACE WITH NAME OF PAGE]

* Updated Project Profile Card review and update issue template

* Update issue templates

updated designer time

* Updated Credits file template: Edit content field and remove type field

* Updated Credits file template: Edit content field and remove type field

* Update meeting data

* Update contributor and language data

* Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072)

* Update meeting data

* Update contributor and language data

* Added feature-tech-dropdown branch

* Update meeting data

* Added feature-tech-dropdown branch

* Added feature-tech-dropdown branch

* Update contributor and language data

* changed the spelling from webapp to web app on line 56 (hackforla#3073)

* Update meeting data

* Update contributor and language data

* Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078)

This reverts commit f6deeff.

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079)

* Delete unused project-filter.js file (hackforla#3081)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076)

* fixed spelling of non-profit to nonprofit, line 77, join-us.html

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Add so go survey credit page 3022 (hackforla#3043)

* add new headers and tools section to credit page

* updated to empty alt tags for tools section

* fix snytax errors

* fix spacing in code and website page

* Fix indentation and add functionality for additional teams in "By:" field

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edited items on how to pick up your first issue.

Edited items on how to pick up your first issue.

* Create new Privacy Policy page and its credit, and edit label (hackforla#3083)

* Added privacy-policy.jpg

* Add privacy-policy.yml to credits

* Added initial privacy-policy scss and html files

* Added header and overview section

* Redoing the html page from scratch

* Added a line in main.scss to import privacy-policy.scss

* Added header section

* Added the content for section Visiting HackforLA.org

* Added content for section Email Addresses

* Added content for Google Analytics section

* Added content up through and including Third party service providers section

* Finished adding all the content in the HTML file

* Moved the import of privacy-policy.scss to the bottom of the components section

Reason is it didn't make sense that I just put it in the middle on the components section without any reason.

* Added styling for desktop version of page

* Added mobile styling and finished desktop styling

* Updated privacy-policy.yml credit

* Fixed styling

* Fixed styling

* Added spacing before the address on the bottom of the page

* Clarified "Project Profile Card review and update" template

* Update meeting data

* Update contributor and language data

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Saumil Dhankar <[email protected]>
Co-authored-by: Poorvi Rao <[email protected]>
Co-authored-by: Bonnie Wolfe <[email protected]>
Co-authored-by: Wilny Duong <[email protected]>
Co-authored-by: gardenqu <[email protected]>
Co-authored-by: Simone Campbell <[email protected]>
Co-authored-by: Trisha Johnson <[email protected]>
Co-authored-by: Erick Odero <[email protected]>
Co-authored-by: Devin Krizwold <[email protected]>
Co-authored-by: Matthew Arofin <[email protected]>
Co-authored-by: Jay Barbanel <[email protected]>
Co-authored-by: Jaret Balba <[email protected]>

Co-authored-by: Sarah W <[email protected]>
Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Saumil Dhankar <[email protected]>
Co-authored-by: Poorvi Rao <[email protected]>
Co-authored-by: Bonnie Wolfe <[email protected]>
Co-authored-by: Wilny Duong <[email protected]>
Co-authored-by: gardenqu <[email protected]>
Co-authored-by: Simone Campbell <[email protected]>
Co-authored-by: Trisha Johnson <[email protected]>
Co-authored-by: Erick Odero <[email protected]>
Co-authored-by: Devin Krizwold <[email protected]>
Co-authored-by: Matthew Arofin <[email protected]>
Co-authored-by: Jay Barbanel <[email protected]>
Co-authored-by: Jaret Balba <[email protected]>
JessicaLucindaCheng added a commit to JessicaLucindaCheng/website that referenced this pull request May 14, 2022
@JessicaLucindaCheng @HackforLABot
@SAUMILDHANKAR @poorvi4 @ExperimentsInHonesty @Wny-Duong @gardenqu @sacamp @trishajjohnson @eodero @Sparky-code @matt-arofin @JayBarbanel @Jaretzbalba
Sm 1 feature homepage launch (#25)
7746e31 
* Update meeting data

* Update meeting data

* Update contributor and language data

* Added few points to issue progression action item

Added few points to issue progression action item

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update add labels trigger hackforla#2939 (hackforla#3042)

* Update add-labels-template.md

* Update add-labels-template.md

Rearranged original note

* Update open-community-survey.md

* Updated pre-work developer template

* Changed typo in _projects/home-unite-us.md from 'non-profits' to 'nonprofits'. (hackforla#3062)

* Update meeting data

* Update contributor and language data

* fixed the spelling of sustainability (hackforla#3067)

* Update pre-work dev issue template

* Update meeting data

* Update contributor and language data

* Update issue templates

Added Wiki: Research Plan Review:  [REPLACE WITH NAME OF PAGE]

* Updated Project Profile Card review and update issue template

* Update issue templates

updated designer time

* Updated Credits file template: Edit content field and remove type field

* Updated Credits file template: Edit content field and remove type field

* Update meeting data

* Update contributor and language data

* Fix misspelling of "community" on line 93 of pages/join-us.html (hackforla#3072)

* Update meeting data

* Update contributor and language data

* Added feature-tech-dropdown branch

* Update meeting data

* Added feature-tech-dropdown branch

* Added feature-tech-dropdown branch

* Update contributor and language data

* changed the spelling from webapp to web app on line 56 (hackforla#3073)

* Update meeting data

* Update contributor and language data

* Revert " changed the spelling from webapp to web app on line 56 (hackforla#3073)" (hackforla#3078)

This reverts commit f6deeff.

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edit content field and remove type field from avatar.yml credits file 2793 (hackforla#3079)

* Delete unused project-filter.js file (hackforla#3081)

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* fixed spelling of non-profit to nonprofit, line 77, join-us.html (hackforla#3076)

* fixed spelling of non-profit to nonprofit, line 77, join-us.html

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Add so go survey credit page 3022 (hackforla#3043)

* add new headers and tools section to credit page

* updated to empty alt tags for tools section

* fix snytax errors

* fix spacing in code and website page

* Fix indentation and add functionality for additional teams in "By:" field

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Update meeting data

* Update contributor and language data

* Edited items on how to pick up your first issue.

Edited items on how to pick up your first issue.

* Create new Privacy Policy page and its credit, and edit label (hackforla#3083)

* Added privacy-policy.jpg

* Add privacy-policy.yml to credits

* Added initial privacy-policy scss and html files

* Added header and overview section

* Redoing the html page from scratch

* Added a line in main.scss to import privacy-policy.scss

* Added header section

* Added the content for section Visiting HackforLA.org

* Added content for section Email Addresses

* Added content for Google Analytics section

* Added content up through and including Third party service providers section

* Finished adding all the content in the HTML file

* Moved the import of privacy-policy.scss to the bottom of the components section

Reason is it didn't make sense that I just put it in the middle on the components section without any reason.

* Added styling for desktop version of page

* Added mobile styling and finished desktop styling

* Updated privacy-policy.yml credit

* Fixed styling

* Fixed styling

* Added spacing before the address on the bottom of the page

* Clarified "Project Profile Card review and update" template

* Update meeting data

* Update contributor and language data

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Saumil Dhankar <[email protected]>
Co-authored-by: Poorvi Rao <[email protected]>
Co-authored-by: Bonnie Wolfe <[email protected]>
Co-authored-by: Wilny Duong <[email protected]>
Co-authored-by: gardenqu <[email protected]>
Co-authored-by: Simone Campbell <[email protected]>
Co-authored-by: Trisha Johnson <[email protected]>
Co-authored-by: Erick Odero <[email protected]>
Co-authored-by: Devin Krizwold <[email protected]>
Co-authored-by: Matthew Arofin <[email protected]>
Co-authored-by: Jay Barbanel <[email protected]>
Co-authored-by: Jaret Balba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlos-A-P Carlos-A-P Carlos-A-P approved these changes

@tamara-snyder tamara-snyder tamara-snyder approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Join Page https://www.hackforla.org/join role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix misspelled word on join-us.html file from "commmunity" to "community"
3 participants
@trishajjohnson @Carlos-A-P @tamara-snyder