Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SCSS #technologies #2761

Conversation

JessicaLucindaCheng
Copy link
Member

@JessicaLucindaCheng JessicaLucindaCheng commented Feb 10, 2022

Fixes #2754 and #2397

What changes did you make and why did you make them?

  • This is a follow up to pr Revert pr 2724 and pr 2672 to fix proj profile page bug #2757. PR Revert pr 2724 and pr 2672 to fix proj profile page bug #2757 was a temporary fix that removed the mobile languages/technology dropdown with scrollbar and the desktop languages/technology dropdown with scrollbar and 4 columns from the projects page in order to fix the problem with the detail information project pages having a large gap and technologies field not being wrapped. This pr is to fix the detail information project pages having a large gap and technologies field not being wrapped while still having on the projects page the mobile languages/technology dropdown with scrollbar and the desktop languages/technology dropdown with scrollbar and 4 columns.
  • I changed #technologies to ul.dropdown#technologies because ul.dropdown#technologies has a higher specificity than #technologies. Also, SCSS #technologies caused problems with the technologies field on the detailed project page since it also has an id="technologies"; this caused a problem because all the SCSS files are compiled into a main.scss, which is shared sitewide by all webpages.
  • I combined ul.filter-list li ul and ul.dropdown#technologies into one @media #{$bp-below-tablet} to make it so there wasn't multiple media queries with the same $bp-below-tablet parameter.
  • I edited the comments related to the media queries to make them clearer.
  • 2/15/2022 I changed the languages/technologies dropdown to be 3 columns instead of 4 columns to address the problem of gaps being created when a menu item had to wrap its text onto a second line and make other menu items that only needed 1 line to have gaps. (See bullet point 3 in this comment for a picture and more details: Update the Technologies dropdown in the Projects page to match the Figma design #2397 (comment))

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Mobile view of Languages/Technologies dropdown
before-mobile-proj-tech-lang-filter

Desktop view of Languages/Technologies dropdown
before-desktop-proj-tech-lang-filter

Desktop view of 311 Data project page
before-311-data

Desktop view of Civic Tech Jobs project page
before-civic-tech-jobs

Desktop view of Civic Tech Index project page
before-civic-tech-index

Desktop view of Food Oasis project page
before-food-oasis

Visuals after changes are applied

Mobile view of Languages/Technologies dropdown
after-mobile-proj-tech-lang-filter

Desktop view of Languages/Technologies dropdown
after-desktop-tech-dropdown

Desktop view of 311 Data project page (should look the same as the before image and putting it here to show it is the same)
after-311-data

Desktop view of Civic Tech Jobs project page (should look the same as the before image and putting it here to show it is the same)
after-civic-tech-jobs

Desktop view of Civic Tech Index project page (should look the same as the before image and putting it here to show it is the same)
after-civic-tech-index

Desktop view of Food Oasis project page (should look the same as the before image and putting it here to show it is the same)
after-food-oasis

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b JessicaLucindaCheng-fix-id-technologies-2754 gh-pages
git pull https://github.com/JessicaLucindaCheng/website.git fix-id-technologies-2754

@github-actions github-actions bot added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages Fun Congrats! You finished two good first issues. Please only do one of these P-Feature: Getting Started https://www.hackforla.org/getting-started role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review labels Feb 10, 2022
@JessicaLucindaCheng JessicaLucindaCheng marked this pull request as ready for review February 10, 2022 02:03
@JessicaLucindaCheng JessicaLucindaCheng changed the title Fixes SCSS #technologies Fixes SCSS #technologies Feb 10, 2022
@SAUMILDHANKAR

This comment was marked as outdated.

@SAUMILDHANKAR
Copy link
Member

Review ETA: EOD 2/14/22
Availability: Few hours most days

@github-actions github-actions bot added Bug Something isn't working P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 1pt Can be done in 4-6 hours Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ Complexity: Large and removed Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Getting Started https://www.hackforla.org/getting-started Complexity: Small Take this type of issues after the successful merge of your second good first issue Fun Congrats! You finished two good first issues. Please only do one of these Complexity: Large P-Feature: Projects page https://www.hackforla.org/projects/ labels Feb 12, 2022
@github-actions github-actions bot added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ Complexity: Large labels Feb 13, 2022
…, so that each menu item fits in 1 row and doesn't need to wrap
@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Feb 15, 2022

Revised Review ETA: EOD 2/19/22
Availability: Saturday 8-10 PM

@JessicaLucindaCheng
Copy link
Member Author

@SAUMILDHANKAR I just pushed a commit and added the following to my original pr post:

2/15/2022 I changed the languages/technologies dropdown to be 3 columns instead of 4 columns to address the problem of gaps being created when a menu item had to wrap its text onto a second line and make other menu items that only needed 1 line to have gaps. (See bullet point 3 in this comment for a picture and more details: #2397 (comment))

Also, I updated the picture for the after visual for the dropdown with 3 columns.

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Feb 15, 2022

@SAUMILDHANKAR Also, added the following note to this comment: #2397 (comment)

Also, note that the mobile Languages/Technologies dropdown in the Figma design has each menu item take up one line but the font size is 12px, which is smaller than the recommended minimum size of a 16px font. Thus, the current Languages/Technologies dropdown (even before adding the scrollbar) and the Status and Program Areas may have some menu item text wrapping to a second line because the current font size for the dropdowns is 16px. If you want each menu item in each dropdown to be on one line, we can address that problem in a separate issue for all the dropdowns.

@github-actions github-actions bot added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ Complexity: Large and removed Complexity: Large Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ labels Feb 20, 2022
@JessicaLucindaCheng JessicaLucindaCheng added Status: Updated No blockers and update is ready for review and removed Complexity: Large Status: Updated No blockers and update is ready for review Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages P-Feature: Projects page https://www.hackforla.org/projects/ labels Feb 20, 2022
@SAUMILDHANKAR
Copy link
Member

Revised Review ETA: EOD 2/21/22
Availability: Monday 4-6 PM

SAUMILDHANKAR
SAUMILDHANKAR previously approved these changes Feb 23, 2022
Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaLucindaCheng Changes look good to me. I can see 3 columns for tech dropdown in desktop version. Project pages look fine as well. I will merge this to a new feature branch called feature-tech-dropdown. Next steps would be discussion regarding making the dropdown dynamic and any other changes required before merging this feature branch to gh-pages. Thanks a lot for working on this.

@SAUMILDHANKAR SAUMILDHANKAR changed the base branch from gh-pages to feature-tech-dropdown February 23, 2022 08:28
@SAUMILDHANKAR SAUMILDHANKAR dismissed their stale review February 23, 2022 08:28

The base branch was changed.

Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JessicaLucindaCheng Changes look good to me. I can see 3 columns for tech dropdown in desktop version. Project pages look fine as well. I will merge this to a new feature branch called feature-tech-dropdown. Next steps would be discussion regarding making the dropdown dynamic and any other changes required before merging this feature branch to gh-pages. Thanks a lot for working on this.

@SAUMILDHANKAR SAUMILDHANKAR merged commit ab45eda into hackforla:feature-tech-dropdown Feb 23, 2022
@JessicaLucindaCheng JessicaLucindaCheng deleted the fix-id-technologies-2754 branch February 23, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Project Profile page bug: Technologies not wrapping
2 participants