Skip to content

Commit

Permalink
Fixes SCSS #technologies (#2761)
Browse files Browse the repository at this point in the history
* Revert "Revert "Update tech dropdown 2397 (#2672)""

This reverts commit d41be43.

* Revert "Revert "Removed comments unrelated to pr 2672 from variables/_layout.scss (#2724)""

This reverts commit 17a63fc.

* Updated comments and #technologies to ul.dropdown#technologies

* Clarified comments

* Clarified comments and changed the lang/tech dropdown to be 3 columns, so that each menu item fits in 1 row and doesn't need to wrap
  • Loading branch information
JessicaLucindaCheng authored Feb 23, 2022
1 parent 7164ec2 commit ab45eda
Showing 1 changed file with 35 additions and 4 deletions.
39 changes: 35 additions & 4 deletions _sass/components/_project-filter.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@ a.filter-item {
//filter container
ul.filter-list {
background: $color-pink;
display: grid;
list-style: none;
padding-left: 0;
grid-auto-flow: column;
list-style: none;
display: grid;
grid-column-gap: 20px;
// grid-template-columns: repeat(4, 1fr);
// ^ See issue #1997 for more info on why this is commented out and changed to 3
Expand Down Expand Up @@ -160,11 +159,43 @@ a.clear-filter-tags {
color: $color-red;
}

// Below tablet size, including mobile size
@media #{$bp-below-tablet} {
//resize dropdown on tablet and mobile view
// Resize dropdown
ul.filter-list li ul {
width: 105%;
padding: 15px;
overflow: auto;
}

// Adds scrollbar and limits height for Languages/Technologies dropdown
ul.dropdown#technologies {
height: 370px;
overflow: auto;
}
}

// Tablet size and up
@media #{$bp-tablet-up} {
// Adds scrollbar and makes Languages/Technologies dropdown three columns
ul.dropdown#technologies {
display: grid;
grid-auto-flow: column; // flows the data from top to bottom rather than left to right
grid-template-rows: repeat(23, 1fr); // ensures the list is 23 rows
list-style: none;
left: -17em;
width: 718px;
height: 380px;
overflow: auto;
}
}

// Desktop size and up
@media #{$bp-desktop-up} {
// Adjusts placement of Languages/Technologies dropdown and adjusts dropdown width
ul.dropdown#technologies {
left: -18em;
width: 768px;
}
}

Expand Down

0 comments on commit ab45eda

Please sign in to comment.