Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds projects onto homepage with filters #261

Conversation

StephenVNelson
Copy link
Contributor

Pull request resolves #254

fix size and aspect ratio of not today image (hackforla#166)
…ust the projects page so the project page can be added later.
@cnk
Copy link
Member

cnk commented Feb 9, 2020

The filters work and I think this is an excellent feature to add to the homepage. Before merging it into master, I would love to see a couple of UI items addressed.

HackforLAFilters

  1. This isn't sorting, it is filtering. Could we change "Sort by" to "Filter by"?
  2. And could we get a little space between that heading and the dropdowns? 10px or so is sufficient.
  3. Could we please have labels for the drop downs (Locations and Status) and then have the default option for each be "ALL"?
  4. Topo: WESTIDE -> WESTSIDE
  5. Is there a reason for using all caps for the options? DTLA is an abbreviation but I usually see WESTSIDE as Westside. (I am fine with leaving all caps if there is an active preference for that display)
  6. And this code appears to have lost whatever is keeping the cards all the same height (or at least the cards next to each other the same height). So we should figure out what that is and restore it before merging.

@thekaveman
Copy link
Member

thekaveman commented Feb 11, 2020

  1. This isn't sorting, it is filtering. Could we change "Sort by" to "Filter by"?

Or can we change the behavior? The original Issue called for filtering, was there a decision to go with sorting instead? Seems like filtering might be more useful.

Sorry I think I misunderstood the comment.

@StephenVNelson
Copy link
Contributor Author

StephenVNelson commented Feb 12, 2020 via email

@ExperimentsInHonesty
Copy link
Member

@StephenVNelson
Re the comments in this link:
#261 (comment)

  1. This isn't sorting, it is filtering. Could we change "Sort by" to "Filter by"?
    A: Please change to filter by.

  2. And could we get a little space between that heading and the dropdowns? 10px or so is sufficient.
    A: yes, please add that, sort by is too close to the dropdowns.

  3. Could we please have labels for the drop downs (Locations and Status) and then have the default option for each be "ALL"?
    A: Lets change the drop down to have a tile and then the drop down after it, with a default ALL
    Location: [drop down would then appear with the text "ALL"]
    Status: [drop down would then appear with the text "ALL"]

  4. Topo: WESTIDE -> WESTSIDE

  5. Is there a reason for using all caps for the options? DTLA is an abbreviation but I usually see WESTSIDE as Westside. (I am fine with leaving all caps if there is an active preference for that display)
    A: Choices should be ALL, DTLA, SouthLA, Westside

  6. And this code appears to have lost whatever is keeping the cards all the same height (or at least the cards next to each other the same height). So we should figure out what that is and restore it before merging.
    A: YES, please do

@cnk
Copy link
Member

cnk commented Jun 29, 2020

This gave us a starting place but is being superceded by work in #566 so I am going to close this.

@cnk cnk closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create project filtering on HFLA Home Page
4 participants