Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix size and aspect ratio of not today image #166

Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix size and aspect ratio of not today image #166

merged 1 commit into from
Nov 14, 2019

Conversation

brentjayingram
Copy link
Member

I made the aspect ratio 600x400 with white padding on each side.

@brentjayingram
Copy link
Member Author

This is in regards to issue #161

@McRawly McRawly self-requested a review October 30, 2019 17:48
@sarL3y
Copy link
Member

sarL3y commented Nov 5, 2019

@bingr001 Hey Brent! Feel free to hop on our Slack if you'd like to chat about the project. Thank you for the help! hackforla.org/slack

@ExperimentsInHonesty
Copy link
Member

@bingr001 the language you need to use on github to tie a pull request to an issue is
fixes issue #161

@Vallsurf are you reviewing this?

@brentjayingram
Copy link
Member Author

Thanks @ExperimentsInHonesty
fixes issue #161

Vallsurf
Vallsurf approved these changes Nov 13, 2019
View reviewed changes
Copy link

@Vallsurf Vallsurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reaches the intended result of a proper aspect ratio for the not today image, although it looks like there should be more control on the CSS side rather than changing the file size directly.

@brentjayingram brentjayingram mentioned this pull request Nov 13, 2019
Closed
1 task
@ExperimentsInHonesty ExperimentsInHonesty merged commit 5bc15bd into hackforla:gh-pages Nov 14, 2019
@ExperimentsInHonesty
Copy link
Member

I am satisfied that fixing the image is the solution that is appropriate here.

StephenVNelson added a commit to StephenVNelson/website that referenced this pull request Nov 26, 2019
@StephenVNelson
Merge pull request #1 from hackforla/gh-pages
5a35008 
fix size and aspect ratio of not today image (hackforla#166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vallsurf Vallsurf Vallsurf approved these changes

@McRawly McRawly Awaiting requested review from McRawly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brentjayingram @sarL3y @ExperimentsInHonesty @Vallsurf