Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design systems project info for display #2365

Merged

Conversation

abuna1985
Copy link
Member

@abuna1985 abuna1985 commented Oct 12, 2021

Fixes #2255

What changes did you make and why did you make them?

  • Added assets/images/projects/design-systems-hero.jpg & assets/images/projects/design-systems.jpg for the design system project
  • Added _projects/design-systems.md with the relevant information provided in the issue

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals after changes are applied (desktop)

Hack for L.A. projects design systems page - desktop version

Hack for L.A. projects design systems page - desktop version

Hack for L.A. projects design systems card - desktop version

Hack for L.A. projects design systems card - desktop version
Visuals after changes are applied (mobile)

Hack for L.A. projects design systems page - mobile version

Hack for L.A. projects design systems page - mobile version

Hack for L.A. projects design systems card - mobile version

Hack for L.A. projects design systems card - mobile version

@github-actions github-actions bot added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue time sensitive Needs to be worked on by a particular timeframe To Update ! No update has been provided labels Oct 12, 2021
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b abuna1985-2255-add-design-systems-project-page gh-pages
git pull https://github.com/abuna1985/website.git 2255-add-design-systems-project-page

@abuna1985 abuna1985 removed the To Update ! No update has been provided label Oct 12, 2021
_projects/design-systems.md Outdated Show resolved Hide resolved
@abuna1985 abuna1985 requested a review from macho-catt October 12, 2021 19:19
@abuna1985 abuna1985 added the hacktoberfest-accepted Makes a pull request be counted as verified and valid label Oct 13, 2021
Copy link
Member

@macho-catt macho-catt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Good job as always!

@macho-catt macho-catt merged commit c74ef07 into hackforla:gh-pages Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue hacktoberfest-accepted Makes a pull request be counted as verified and valid P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new project to website: Design Systems
2 participants