Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new project to website: Design Systems #2255

Closed
17 of 20 tasks
ExperimentsInHonesty opened this issue Sep 13, 2021 · 22 comments · Fixed by #2365, #2371, #2376 or #2398
Closed
17 of 20 tasks

Add new project to website: Design Systems #2255

ExperimentsInHonesty opened this issue Sep 13, 2021 · 22 comments · Fixed by #2365, #2371, #2376 or #2398
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Sep 13, 2021

Overview

We need to add a new project to the hack for la website so that our project list can be current

Project Details

  • Name: Design-Systems
  • Name of future project.md file: design-systems.md
  • Files you will need to upload to the website repository: design-systems.jpg and design-system-hero.jpg
  • Where you will store the files:
    • images go in this folder: /assets/images/projects
    • project.md file goes in this folder: _projects

Action Items

  • Take the content listed here and create a new project.md card (skip anything that has strikethrough)
  • Download the images
  • Add both project card and images to appropriate folders
  • Once you have it working on your local environment
    • Take screen shots of the project card on the homepage and the projects project page adding them to issue
    • Reach out to the product manager to ask if they are satisfied by adding a comment to this issue with a link to the screenshots on your issue
  • Submit pull request
  • Let Product Manager know when its live

Resources

Template for project.md files

Content of the project.md card

  • A link to the 600 x 400 image
  • Alt image text - 'Hack for LA logo and the title of the project, Design Systems'
  • A link to the 1500 x 700 hero image
  • Name of project: Design Systems
  • A blurb about your project:
The Design System initiative seeks  to empower volunteers with the tools, documentation and templates for creating and maintaining a design system for their HfLA projects.  As Hack for LA continues to scale it has become more essential to create consistent documentation and standards for design deliverables. 

A Design System is a single source of truth for a website’s designers and developers– a collection of reusable components, styles, and code guided by clear standards and documentation. Design systems are now an industry standard used by the website teams of most major companies.
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 13, 2021
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers Size: Good second issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 13, 2021
@ExperimentsInHonesty ExperimentsInHonesty added the time sensitive Needs to be worked on by a particular timeframe label Sep 13, 2021
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Size: Good second issue labels Sep 20, 2021
@abuna1985 abuna1985 self-assigned this Sep 23, 2021
@github-actions
Copy link

@abuna1985

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Sep 24, 2021
@abuna1985
Copy link
Member

Screenshots of the proposed changes

Click here to screenshots of the proposed Design Systems project card

Project card (desktop)

Project card (mobile)

Click here to screenshots of the proposed Design Systems project profile

Design Systems project profile (desktop)

Design Systems project profile (mobile)

@abuna1985
Copy link
Member

abuna1985 commented Sep 24, 2021

Update

  1. Completed changes. Awaiting approval from @hannahlivnat to complete PR
  2. Just awaiting PM approval
  3. Will be available Sunday/Monday to complete this
  4. By the end of next week.

@abuna1985 abuna1985 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Sep 24, 2021
@Hanastevenson
Copy link
Member

Hanastevenson commented Sep 24, 2021

Hi @abuna1985

Thanks for the update. The project card works. The Project profile needs some adjustment. In the current screen shot provide by you there seems to be little padding from the top of the artwork to the navigation.

Please see below the preferred layout. I've left in the bounding box to illustrate. The artwork size needs to be reduced to align with the sides of the 'project overview' white boxes underneath.
Screenshot 2021-09-24 at 14 41 59

@Hanastevenson
Copy link
Member

@ExperimentsInHonesty Do we need to review the copy? Highlighting the fact this initiative goes across 20+ product teams?

@ExperimentsInHonesty
Copy link
Member Author

@Hanastevenson i think we took this text from the one sheet. Maybe we should revisit both.

@abuna1985

This comment has been minimized.

@abuna1985
Copy link
Member

abuna1985 commented Oct 4, 2021

@ahoang94 Where is the path to the 'Branding and Assets' folder? Could you provide a direct link to the image?

@ahoang94
Copy link
Member

ahoang94 commented Oct 4, 2021

@github-actions github-actions bot added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Oct 8, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

@abuna1985

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 5, 2021 at 12:02 AM PST.

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Oct 11, 2021

@abuna1985 Can we get a PR in for adding the design systems team to the website today?

@abuna1985
Copy link
Member

abuna1985 commented Oct 12, 2021

@ExperimentsInHonesty @Hanastevenson Thank you so much for your patience. My apologies for the delay. I have submitted pull request #2365. I will also attach screenshots below for you to see the final changes made.

Project Card/Page final version (desktop)

Hack for L.A. projects design systems page - desktop version

Hack for L.A. projects design systems page - desktop version

Hack for L.A. projects design systems card - desktop version

Hack for L.A. projects design systems card - desktop version
Project Card/Page final version (mobile)

Hack for L.A. projects design systems page - mobile version

Hack for L.A. projects design systems page - mobile version

Hack for L.A. projects design systems card - mobile version

Hack for L.A. projects design systems card - mobile version

Let me know if you have any questions. 👋 👋 👋

@abuna1985 abuna1985 removed the To Update ! No update has been provided label Oct 12, 2021
@Hanastevenson
Copy link
Member

@abuna1985 @ExperimentsInHonesty
Hi Adam,
Thank you for the update. One small query, on the mobile design are you able to shift the H1 down so there is less padding between the H1 and the card? I understand this may be an extra ticket as it could affect all other project cards, please proceed.

@ExperimentsInHonesty
Copy link
Member Author

ExperimentsInHonesty commented Oct 17, 2021

@abuna1985 does not seem connected to the repo because its not showing "All Time Contributors" section
see https://www.hackforla.org/projects/design-systems

image

@abuna1985
Copy link
Member

@hackforla/website-merge reopening this issue to make edits and get all-time contributors added

@abuna1985
Copy link
Member

Reopening for 1 more round of edits

@abuna1985 abuna1985 reopened this Oct 21, 2021
@abuna1985
Copy link
Member

abuna1985 commented Oct 21, 2021

@Hanastevenson Can you please add the following topic to the Design Systems repository (https://github.com/hackforla/design-systems):

  • hack-for-la

Note: I have included a link for an article from GitHub on how to add topics

This will help when we are collecting the data from your repo for the project details page.

Thank you! 👋 👋 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review time sensitive Needs to be worked on by a particular timeframe
Projects
5 participants