Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buttons on communities of practice and program areas pages #2352

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Refactor buttons on communities of practice and program areas pages #2352

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
542e705
Refactor buttons on communities of practice and program areas pages
Zhu-Joseph Oct 10, 2021
dd8ca10
Update CSS for buttons
Zhu-Joseph Oct 12, 2021
2db2a6f
Update scss to standardize styling
Zhu-Joseph Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions _sass/components/_communities-of-practice.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,7 @@
margin-bottom: 10px;
font-size: 14px;
}

.align-center a {
abuna1985 marked this conversation as resolved.
Show resolved Hide resolved
display: inline-flex;
}
4 changes: 4 additions & 0 deletions _sass/components/_program-areas.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,3 +163,7 @@
.join-us-footer-paragraphs {
margin-bottom: 48px;
}

.join-us-footer-body a {
abuna1985 marked this conversation as resolved.
Show resolved Hide resolved
display: inline-flex;
}
4 changes: 2 additions & 2 deletions pages/communities-of-practice.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ <h3>{{ community[1].name}}</h3>
{% endif %}
<div class="align-center">
{% if community[1].links[0].url %}
<a href="{{ community[1].links[0].url }}"><button class="btn btn-primary btn-md">Join Meeting Slack Channel</button></a>
<a href="{{ community[1].links[0].url }}" class="btn btn-primary btn-md btn--default" target="_blank" title="{{community[1].name}} Slack channel">Join Meeting Slack Channel</a>
{% elsif community[1].links[1].url %}
<a href="{{ community[1].links[1].url }}"><button class="btn btn-primary btn-md">View GitHub</button></a>
<a href="{{ community[1].links[0].url }}" class="btn btn-primary btn-md btn--default" target="_blank" title="{{community[1].name}} Github Repo">View GitHub</a>
{% else %}
<button class="btn btn-primary btn-md">Coming soon...</button>
{% endif %}
Expand Down
7 changes: 1 addition & 6 deletions pages/program-areas.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,7 @@ <h3>Join a Project</h3>
channel name.
</p>
</div>
<a href="https://www.hackforla.org/join" target="_blank">
<button class="btn btn-primary btn-md">Join Us</button>
</a>

<a href="/join" class="btn btn-primary btn-md btn--default">Join Us</a>
</div>


</div>
</section>