Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buttons on communities of practice and program areas pages #2352

Conversation

Zhu-Joseph
Copy link
Member

Fixes #2158

What changes did you make and why did you make them ?

  • Updated button on line 69 on communities of practice page website/pages/communities-of-practice.html
  • Updated button on line 71 on communities of practice page website/pages/communities-of-practice.html
  • Updated button on line 87 on program areas page website/pages/program-areas.html

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Before

Visuals after changes are applied

After

@github-actions github-actions bot added Feature: Design system Feature: Refactor HTML role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review labels Oct 10, 2021
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Zhu-Joseph-refactor-buttons-community-of-practice-and-program-area gh-pages
git pull https://github.com/Zhu-Joseph/website.git refactor-buttons-community-of-practice-and-program-area

Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zhu-Joseph Thank you for your pull request. My apologies for not being clear in the issue. The button should look the same as before. We need to add css to the specific button elements to make sure they match the before picture. Let me know if you have any questions. Thank you. 🌟 🌟 🌟

@Zhu-Joseph
Copy link
Member Author

@Zhu-Joseph Thank you for your pull request. My apologies for not being clear in the issue. The button should look the same as before. We need to add css to the specific button elements to make sure they match the before picture. Let me know if you have any questions. Thank you. 🌟 🌟 🌟

@abuna1985 Hi Adam, I updated the code and made a commit. I did have to update the css to get the buttons to match what they looked like before. Below is an image of the updated code.

Visuals Changed

After2

@abuna1985 abuna1985 added the hacktoberfest-accepted Makes a pull request be counted as verified and valid label Oct 13, 2021
Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zhu-Joseph My apologies for the continuous edits. This is my last one. Can you:

  1. Remove the scss files changes (comments in Files Changed)
  2. Edit the btn--default class in _sass/elements/_buttons.scss

From

display: flex;

To
display: inline-flex;

This will consolidate the styling since all our buttons are links now. As soon as this is updated, I will approve and merge.

Thank you!

_sass/components/_communities-of-practice.scss Outdated Show resolved Hide resolved
_sass/components/_program-areas.scss Outdated Show resolved Hide resolved
@abuna1985 abuna1985 removed the Status: Updated No blockers and update is ready for review label Oct 14, 2021
@Zhu-Joseph
Copy link
Member Author

@Zhu-Joseph My apologies for the continuous edits. This is my last one. Can you:

  1. Remove the scss files changes (comments in Files Changed)
  2. Edit the btn--default class in _sass/elements/_buttons.scss

From

display: flex;

To display: inline-flex;

This will consolidate the styling since all our buttons are links now. As soon as this is updated, I will approve and merge.

Thank you!

Hi Adam,

I made the following changes:

  • Removed commented code
  • Updated line 40 on _sass/elements/_buttons.scss to display: inline-flex;

Please let me know if there is anything else you would need me to do!

Copy link
Member

@abuna1985 abuna1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zhu-Joseph Thank you again for making another round of changes and for helping us refactor our buttons. I was able to review the changes and everything looks good to me. I am going to approve and merge this. Keep up the great work! ⭐ ⭐ ⭐

@abuna1985 abuna1985 merged commit 65e3857 into hackforla:gh-pages Oct 19, 2021
@Zhu-Joseph Zhu-Joseph deleted the refactor-buttons-community-of-practice-and-program-area branch October 19, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor HTML hacktoberfest-accepted Makes a pull request be counted as verified and valid role: front end Tasks for front end developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete refactor/standardization of all buttons within Communities of Practice/Program Areas Page
2 participants