-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor buttons on communities of practice and program areas pages #2352
Refactor buttons on communities of practice and program areas pages #2352
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zhu-Joseph Thank you for your pull request. My apologies for not being clear in the issue. The button should look the same as before. We need to add css to the specific button elements to make sure they match the before picture. Let me know if you have any questions. Thank you. 🌟 🌟 🌟
@abuna1985 Hi Adam, I updated the code and made a commit. I did have to update the css to get the buttons to match what they looked like before. Below is an image of the updated code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zhu-Joseph My apologies for the continuous edits. This is my last one. Can you:
- Remove the scss files changes (comments in Files Changed)
- Edit the
btn--default
class in_sass/elements/_buttons.scss
From
website/_sass/elements/_buttons.scss
Line 40 in 481ab19
display: flex; |
To
display: inline-flex;
This will consolidate the styling since all our buttons are links now. As soon as this is updated, I will approve and merge.
Thank you!
Hi Adam, I made the following changes:
Please let me know if there is anything else you would need me to do! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zhu-Joseph Thank you again for making another round of changes and for helping us refactor our buttons. I was able to review the changes and everything looks good to me. I am going to approve and merge this. Keep up the great work! ⭐ ⭐ ⭐
Fixes #2158
What changes did you make and why did you make them ?
website/pages/communities-of-practice.html
website/pages/communities-of-practice.html
website/pages/program-areas.html
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied