Carlos 1510 fix css on toolkit page #1535
Conversation
There was a problem hiding this comment.
Thank you so much for the quick turnaround!
There is only one thing but it should be a quick fix now that you fixed the rest- the title and 'Suggest..' button are not supposed to be stacked in desktop (only in mobile) - they are supposed to look like this in desktop:
I think this should be able to be fixed by making the "flex-direction: column" property only in mobile size (in .suggest-guide-group)
Thank you!!
@akibrhast I've been noticing that any time I pull from upstream, that gif gets removed.. and i have to manually ask for the change to be discarded. Not sure why, or when, it started happening, but it's been a week or two for sure. |
|
@akibrhast @erikaBell that happens when I update my branches as well. |
|
@sanchece you can find the gif here: https://github.com/hackforla/website/blob/71a9798cc937592d98fe63133c6ad9db5f737898/assets/images/about/hfla-donate.gif and place it back into your branch |
|
Thanks for linking the gif @erikaBell. Fixed stacked button in toolkit page and added back the hfla-donate.gif
|
There was a problem hiding this comment.
I'm seeing that the file paths are there, but I'm not seeing the actual gif in the assets and receive the following error in my terminal when going to the "join-us" page
hfla_site | [2021-05-10 17:15:28] ERROR '/assets/images/about/hfla-donate.gif' not found.
Is this happening for anyone else? @qiqicodes @akibrhast
donation gif not found
There was a problem hiding this comment.
Design looks good, thanks for making the edit @sanchece ! Approved pending the above discussion about the gif^
(FYI, the gif isn't showing up for me either)
|
@sanchece @erikaBell @daniellex0 The gif is not showing up on my end. I also have the same error I've checked the directory, it is missing the gif. This could be the cause of gif not found error. Also, with the mobile display: Current Mobile View
Figma Shows Accordion for Mobile View
|
|
@qiqicodes Yes, the dropdown mobile display is actually for an upcoming issue (this issue is a dependency for that one) |
Fixed #1510