Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Toolkit page's mobile filter #1329

Closed
6 of 8 tasks
daniellex0 opened this issue Mar 26, 2021 · 27 comments
Closed
6 of 8 tasks

Update Toolkit page's mobile filter #1329

daniellex0 opened this issue Mar 26, 2021 · 27 comments
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: missing

Comments

@daniellex0
Copy link
Member

daniellex0 commented Mar 26, 2021

Dependency
#2171

Overview

We need to redesign the Toolkit page mobile filter banner, because the filter categories' font is too small when all filters are displayed in one row in mobile

Action Items

Design

  • Review the Toolkit page filter in mobile (using Inspect Element)
  • View the Homepage filter in mobile for an example of effectively adapting filter to mobile
  • Create a rough recreation of the current Toolkit page mobile filter in the Toolkit page file on Figma
  • Redesign the Toolkit page mobile filter
  • Get design review from UX team

Development

  • Review the mobile (dropdown) version of the Toolkit page filter banner on Figma (in pink rectangle)
  • Develop the mobile-only dropdown filter (should stay same beige banner in tablet and desktop - the change should only be in mobile)

Resources/Instructions

Toolkit page
Figma Toolkit page file (final mobile version in pink rectangle]
Homepage

New mobile version of Toolkit page filter (beige banner):

Screen Shot 2021-04-27 at 9 21 29 AM

@daniellex0
Copy link
Member Author

@shinhope will figure out improvements to desktop version as well

@shinhope
Copy link

mobile version ideas:
image

@shinhope
Copy link

new desktop versions:
image (1)
image (2)

@akibrhast
Copy link
Member

@daniellex0 What is the news on this, where do you want to go with this?

@daniellex0
Copy link
Member Author

@akibrhast We are discussing, will add update here when it's finalized!

@daniellex0
Copy link
Member Author

daniellex0 commented Apr 27, 2021

New final mobile dropdown version of filter:

Screen Shot 2021-04-27 at 9 21 29 AM

See design on Figma (in pink rectangle)

@daniellex0 daniellex0 added P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers and removed role: UI labels Apr 27, 2021
@daniellex0 daniellex0 changed the title Redesign Toolkit page mobile filter banner Update Toolkit page's mobile filter banner May 4, 2021
@daniellex0 daniellex0 changed the title Update Toolkit page's mobile filter banner Update Toolkit page's mobile filter May 5, 2021
@qiqicodes qiqicodes assigned qiqicodes and danyc23 and unassigned qiqicodes May 12, 2021
@qiqicodes
Copy link
Member

@danyc23 Can you let us know your progress in regards to this issue? Thank you =]

Progress:
Blockers:

@danyc23
Copy link
Member

danyc23 commented May 17, 2021

Blockers: Haven't find any blockers yet.
Progress: Working on it.
ETA: May 19, 2021

@wendywilhelm10
Copy link
Contributor

@danyc23 Could you please update your issue?

@danyc23
Copy link
Member

danyc23 commented May 29, 2021

Blockers: No blockers.
Progress: Still working on it.
ETA: June 2, 2021

@qiqicodes qiqicodes added the Status: Updated No blockers and update is ready for review label May 30, 2021
@Sihemgourou
Copy link
Contributor

@danyc23
Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou Sihemgourou removed the Status: Updated No blockers and update is ready for review label Jun 12, 2021
@ExperimentsInHonesty
Copy link
Member

@danyc23 I see that you reassigned this to yourself, but I'll need more info that that, because we didn't have an update from Since May 28th, even though we asked a couple of times. So please provide an update now so I can decide if we can keep you on this issue. Apologies if you notified the team that you were going to be out and I am just unaware. For reference though, you do have to put that information on your issue or ask someone else to do that. Then based on the projected absence we decide to keep you on the issue or put it back in the prioritized backlog.

@danyc23
Copy link
Member

danyc23 commented Jul 20, 2021

@danyc23 I see that you reassigned this to yourself, but I'll need more info that that, because we didn't have an update from Since May 28th, even though we asked a couple of times. So please provide an update now so I can decide if we can keep you on this issue. Apologies if you notified the team that you were going to be out and I am just unaware. For reference though, you do have to put that information on your issue or ask someone else to do that. Then based on the projected absence we decide to keep you on the issue or put it back in the prioritized backlog.

Hi Bonnie, I was away for personal reasons and I mentioned it to Josh. I have done some advancements to this issue and still need to fix some small things to finish the filtering functionality. Attached you will see an image of my progress. Let me know if you have any question

Screen Shot 2021-07-20 at 2 09 52 PM

@ExperimentsInHonesty
Copy link
Member

@danyc23 - I want to talk again to the design team. I'm not satisfied with the solution they have proposed.

@danyc23
Copy link
Member

danyc23 commented Jul 21, 2021

@danyc23 - I want to talk again to the design team. I'm not satisfied with the solution they have proposed.

Ok, I'll be waiting for the new design. Should I move it back to In Review?

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

@danyc23

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 3, 2021 at 7:53 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@github-actions
Copy link

@danyc23

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at a Tuesday or Sunday meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 10, 2021 at 12:10 AM.


Note: This comment was created as part of a GitHub Action during its trial phase. If you find this GitHub Action to be disruptive/unhelpful, or if you believe there might be a bug, please leave a comment on this issue. All feedback will be used to further improve it. Thank you for your time.

@github-actions github-actions bot added the To Update ! No update has been provided label Aug 20, 2021
@github-actions
Copy link

@danyc23

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 17, 2021 at 12:02 AM PST.

@Aveline-art
Copy link
Member

@danyc23 There has been no updates on this, so this issue is being recycled. When you are ready to join us, please come to a meeting so that we can fill you in on our new procedures and get you started with us!

@Aveline-art Aveline-art removed the To Update ! No update has been provided label Aug 25, 2021
@blakes24 blakes24 self-assigned this Aug 26, 2021
@blakes24
Copy link
Member

@hackforla/website-design I have a few questions about the design.

  1. The non-mobile view of this page does not have the option to filter for multiple categories at once, but the proposed mobile view does (checkboxes rather than standard dropdown). I just want to make sure this is correct because it seems like the page should have the same functionality no matter the screen size.

  2. The design for the filter includes a checkbox for the option "all". The other pages on the site that use checkbox dropdowns default to all categories if nothing is selected and do not have a checkbox for all. Should the "all" option be removed to remain consistent with the rest of the site?

  3. The design shows the top bar of the dropdown displaying the category that is selected. This makes sense for a traditional dropdown where only one category can be selected at a time. How should this be handled when multiple categories are selected?

@ExperimentsInHonesty ExperimentsInHonesty added the Dependency An issue is blocking the completion or starting of another issue label Aug 29, 2021
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Aug 29, 2021

@blakes24 sorry about the confusion, the is issue need a new design before we can make the change. I added a dependency

@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Nov 1, 2021
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 1, 2021

@blakes24 we got the design done, so now the issue will go into the prioritized backlog.

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: missing
Projects
Development

No branches or pull requests