1255 refactor current data into data external

[akibrhast]

Fixes #1266

• Refactor the current data into data/external (including fixing the GH actions that populate it)

Please looks at the commit messages for reference to what this pr changes

[cnk]

Looks OK at a glance. Does someone else have time to review it properly?

[cnk]

And I think .github/workflows/_wins-data.yml and .github/workflows/wins-data.yml are 2 versions of the same thing. Suspect only one is in use. Could someone check and delete the one that is no longer in use? In this reorg or in a separate PR.

[akibrhast]

@cnk They are not the same file one is using curl to pull data, one is using node script to pull data. You are right that currently only one of them is in use. The _wins-data.yml is a work in progress that would eventually be used instead of the current wins-data.yml will be deleted and the _wins-data.yml will be renamed to wins-data.yml

[jbubar]

@cnk What would be the best way to review this?
It looks good to me, but I am not sure how to review it because they are github actions

[cnk]

@jbubar For testing substantial changes to GitHub actions, I usually change the triggering conditions so I can run them at will - and then run them in my fork.

But for the changes here, simply changing the directory where the data is written, I think it is sufficient to proofread the files to make sure we caught all places that need to be changed to match.

[jbubar]

Looks good. I proof read it very closely, but I did not test it out. I think it should be good

[jbubar]

Looked over it a few more times, and merged it