Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filter Tags to Homepage project filters #1201

Closed
8 tasks done
daniellex0 opened this issue Mar 14, 2021 · 7 comments
Closed
8 tasks done

Add Filter Tags to Homepage project filters #1201

daniellex0 opened this issue Mar 14, 2021 · 7 comments
Assignees
Labels
Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@daniellex0
Copy link
Member

daniellex0 commented Mar 14, 2021

Overview

We need to add filter tags below the homepage project filters so that users can immediately know which filters they selected, and can remove any filters easily.

This also involves adjusting some of the current filter functionality (selected filter categories no longer turn pink- instead they display the number of filters selected in parentheses)

Action Items

  • Review new design of filter tags in 'Homepage (WIP)' Figma file (in purple rectangle)
    • For help with Figma functionality / a quick tutorial, reach out to @daniellex0 on this issue (or on slack)
  • Research how to add filter tags
  • Add filter tags to homepage, following the Figma design
  • Keep selected filter categories white (instead of changing to pink, as they do now) (see Figma design)
  • Add # of filters selected per category in parentheses (see Figma design)
  • Make sure changes to homepage filters don't affect the Wins page filters
    • If it does affect the Wins page filters, apply the filter tags above to the Wins page as well

Resources/Instructions

Homepage
Figma design for homepage filter tags (in purple rectangle)
Example of filter tags in Best Buy website
Wins page

New filter tag designs (click arrow)

One filter selected:

Screen Shot 2021-03-13 at 4 44 24 PM

Multiple filters selected:

Screen Shot 2021-03-13 at 4 44 19 PM

So that you know what to look for- this is what the filter tags section in the purple rectangle looks like in the Figma homepage file:

Screen Shot 2021-03-13 at 4 31 49 PM

@daniellex0 daniellex0 added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Large labels Mar 14, 2021
@akibrhast akibrhast self-assigned this Mar 15, 2021
@Lol-Whut
Copy link
Member

Call the new class filter-item

@akibrhast
Copy link
Member

Progress

Almost complete. Struggling with css

Blockers

Awaiting Closure on

Availability

Here and There

ETA

Approximately a week from whenever the above PR's are closed

@akibrhast akibrhast added the Status: Updated No blockers and update is ready for review label Mar 21, 2021
@erikaBell erikaBell assigned erikaBell and unassigned akibrhast Mar 23, 2021
@erikaBell
Copy link
Member

@daniellex0 the "(1)" "(2)" and "(5)" placement in the figma design, is the decision to "add" numbers together, under certain cases?

i.e., my question comes up when imagining a scenario where an individual comes to the page, goes to the "Looking" dropdown menu, and decides to checkbox both "Development (12)" and "Content (4)".

"Looking" would then become: "Looking (16)"

I'm assuming "Looking (12), (4), etc.." isn't desired

@akibrhast
Copy link
Member

@erikaBell Its the number of items selected.

goes to the "Looking" dropdown menu, and decides to checkbox both "Development (12)" and "Content (4)".

Looking would then become : "Looking (2)"

@erikaBell
Copy link
Member

@akibrhast Ah, thanks!

@erikaBell
Copy link
Member

Progress update ~

Have added filter tags, & numbers per category in parentheses.
Currently working on getting the URL params to be updated via removed filter tags & "clear all".

add-filter-tags-issue-1201

@erikaBell
Copy link
Member

Progress Update: just need to work out a bug with one of the dropdown menus.

@erikaBell erikaBell removed the role: back end/devOps Tasks for back-end developers label Apr 6, 2021
@Josiah-O Josiah-O added size: missing Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Aug 13, 2023
@ExperimentsInHonesty ExperimentsInHonesty added P-Feature: Wins Page https://www.hackforla.org/wins/ and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

6 participants