Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Update GitHub Action Wiki pages' spreadsheet #4819

Closed
3 tasks done
Tracked by #6402 ...
roslynwythe opened this issue Jun 12, 2023 · 9 comments
Closed
3 tasks done
Tracked by #6402 ...

Epic: Update GitHub Action Wiki pages' spreadsheet #4819

roslynwythe opened this issue Jun 12, 2023 · 9 comments
Assignees
Labels
Complexity: Medium Feature: Wiki ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jun 12, 2023

Overview

We need to make a list of all the wiki pages that need to be updated, or new ones created for GHAs, so that people making issues and developers can find what they need quickly.

Details

  • We need to ensure that every GitHub Action is documented in the wiki, and add sections to each wiki GHA page, that provide information about relevant issue labels as well as information about dependent packages and instructions on how to test the GHA when dependent packages are updated.
  • Some workflows contain many GitHub actions

Action Items

  • Update the spreadsheet with link to each related GHA wiki page, noting if it's missing in spreadsheet
  • Review the issues already mentioned below and update the spreadsheet
  • Release the dependency on Epic: Create GitHub Action Wiki pages #6403

Workflow file list

@roslynwythe roslynwythe added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing Draft Issue is still in the process of being created Feature: Wiki size: 1pt Can be done in 4-6 hours and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Jun 12, 2023
@roslynwythe roslynwythe changed the title Audit and Enhance GHA Wiki Pages Audit and Enhance GitHub Action Wiki Pages Jun 15, 2023
@roslynwythe roslynwythe changed the title Audit and Enhance GitHub Action Wiki Pages Epic: Audit and Enhance GitHub Action Wiki Pages Jun 15, 2023
@roslynwythe roslynwythe added the Complexity: Small Take this type of issues after the successful merge of your second good first issue label Jun 15, 2023
@roslynwythe roslynwythe changed the title Epic: Audit and Enhance GitHub Action Wiki Pages Epic: Update GitHub Action Wiki Pages Jun 15, 2023
@roslynwythe roslynwythe added Issue Making: Level 2 Make issue(s) from an ER or Epic and removed Issue Making: Level 2 Make issue(s) from an ER or Epic labels Jun 15, 2023
@roslynwythe roslynwythe self-assigned this Jun 19, 2023
@github-actions

This comment was marked as outdated.

Copy link

github-actions bot commented Mar 1, 2024

Hi @MarcosG119, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@MarcosG119
Copy link
Member

Availability:

  • Friday 2/29 3pm-6pm
  • Saturday 9am-1pm
  • Sunday 6pm-9pm
  • Monday 3pm-6pm
  • Tuesday 6pm-9pm

ETA:
EOD Wednesday 3/6

@MarcosG119
Copy link
Member

Help Needed:

I believe I've fully updated the spreadsheet, but I'm not 100% sure. I also am not sure how I remove the dependency from the issue, do I just remove the dependency label? Also it seems like for the create issues section it seems those issues have all been created so I'm not sure if I am to take action on those. If someone can provide some clarity it would be greatly appreciated, thank you!

@MarcosG119 MarcosG119 added the Status: Help Wanted Internal assistance is required to make progress label Mar 2, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 4, 2024
@ExperimentsInHonesty
Copy link
Member

@MarcosG119 I added the ready for dev lead label and put this in the questions column. You can always do that if you are unsure of next steps when you have work that you think is ready for review. If its work that anyone on the team could help you with, you can also post in the slack channel with a link to your issue comment.

@roslynwythe
Copy link
Member Author

roslynwythe commented Mar 13, 2024

Hi @MarcosG119 I apologize for the delay in responding. I noticed two issues with the spreadsheet:

  1. Regarding column D - every script is invoked within at least one workflow (column D), sometimes more (column E). You can use the GitHub search or any other full-site text search such as VS Code or text editor to find the .yml or .yaml file that references a .js script.

  2. Regarding column F - Please look at each GHA wiki page linked from https://github.com/hackforla/website/wiki/HfLA-GitHub-Actions and enter the URL in the appropriate row in the spreadsheet. For each GHA wiki page, the name will match either the folder name (which is actuallyor the name of the "job") or the workflow name in one or more rows. For Rows 2-4 you should find GHA wiki pages with titles that match the folder name in column B. For rows 5-8, fill in the URL of the wiki page GHA: issue trigger, since that title matches the name of the workflow for those rows. In all cases where a GHA wiki page is found that matches either the name of the folder or workflow, we will update the page, so please check the checkbox in column H. However for row 13, I don't think we have a GHA wiki page so leave column F blank and check the checkbox in column G. For rows 14 - 19 there may not be GHA wiki pages so leave column F blank and check the checkbox in G.

@roslynwythe
Copy link
Member Author

@MarcosG119 Regarding your question about the issues:

Regarding the third action item, I will release the dependency when this issue is closed. Thanks!

@MarcosG119
Copy link
Member

@roslynwythe thank you for getting back to me!

Regarding column D - every script is invoked within at least one workflow (column D), sometimes more (column E). You
can use the GitHub search or any other full-site text search such as VS Code or text editor to find the .yml or .yaml file that > references a .js script.

Ok I see now the util functions are used by other functions that are used in by yml files, none of the util functions are called directly in any ymls from what I can find. I have updated the workflows to be what workflows each utils script ends up getting used in by some function not in utils.

I have updated the rest of the columns per your comments. Please let me know if there's anything else I must complete!

@ExperimentsInHonesty ExperimentsInHonesty removed the Status: Help Wanted Internal assistance is required to make progress label Mar 19, 2024
@roslynwythe
Copy link
Member Author

@MarcosG119 Great job, thank you for completing this spreadsheet. It will help us to organize issues to document the workflows and jobs.

@roslynwythe roslynwythe changed the title Epic: Update GitHub Action Wiki Pages Epic: Update GitHub Action Wiki pages' spreadsheet Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Wiki ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

3 participants