Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Events page bug with VRMS data not displaying #3701

Closed
4 tasks
Tracked by #950
ExperimentsInHonesty opened this issue Nov 8, 2022 · 2 comments · Fixed by #3833
Closed
4 tasks
Tracked by #950

Fix Events page bug with VRMS data not displaying #3701

ExperimentsInHonesty opened this issue Nov 8, 2022 · 2 comments · Fixed by #3833
Assignees
Labels
Bug Something isn't working Complexity: Large P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers size: missing time sensitive Needs to be worked on by a particular timeframe

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Nov 8, 2022

Overview

We need to get the VRMS team meeting data back onto our Events page so that people can see when we have meetings.

Details

I made an update with the VRMS team in their database for the DevOps community of practice team and its meeting schedule, and now the events page on the hackforla.org website is not loading the data. We need to figure out why and then work with them on a fix (either something I put in the data needs to be removed), or we need to change something in the processing of the data.

  • I made the change on 2022-11-08 and 1 min later the data stopped showing on the events page.
  • I immediately checked a project page, and the event times are still showing there.

I have checked, and meeting data is still showing up on individual event pages. See 311 data's project page (link in the resources)

I cannot remember exactly what I changed but we should be able to look at an older copy of the data and compare

Action Items

  • Investigate _includes/events-page and pages/events.html to find where the data might be disconnected
    • Going to the events page on the published site and checking the console in developer tools may aid in locating the issue
  • Test in your local repo to find a fix that will display the meeting times
  • Ensure that this does not break any other pages that use data from VRMS files, such as the project pages

Resources/Instructions

Pages where VRMS data should be displaying and are not

Pages that are displaying VRMS data

Other

Where we store our event data from VRMS

https://github.com/hackforla/website/blob/gh-pages/_data/external/vrms_data.json

Data as of 2022-11-07 (before the change): https://github.com/hackforla/website/blob/0379993a76c776561de8c18554465d0d4becdace/_data/external/vrms_data.json

Data as of 2022-11-09 (after the change):
https://github.com/hackforla/website/blob/0798902d1bc2b22a51ddd588eb60383e5058fb09/_data/external/vrms_data.json

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Nov 8, 2022
@ExperimentsInHonesty ExperimentsInHonesty added Bug Something isn't working time sensitive Needs to be worked on by a particular timeframe size: missing role: back end/devOps Tasks for back-end developers P-Feature: Events https://www.hackforla.org/events/ and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Nov 8, 2022
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Nov 8, 2022
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: Large time sensitive Needs to be worked on by a particular timeframe and removed time sensitive Needs to be worked on by a particular timeframe size: missing labels Nov 15, 2022
@blulady blulady removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Nov 16, 2022
@blulady blulady closed this as completed Nov 16, 2022
@blulady blulady reopened this Nov 16, 2022
@jyaymie jyaymie self-assigned this Jan 15, 2023
@github-actions
Copy link

Hi @jyaymie, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@jyaymie
Copy link
Member

jyaymie commented Jan 15, 2023

Availability: After 5pm throughout the week of 1/16/22
ETA: 1/23/22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Large P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers size: missing time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

3 participants