Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters implemented with new state, different selectors #1831

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Jonathanko52
Copy link
Member

Fixes #1646

What changes did you make?

-Kept state in the visibility and status popups.
-Used our own Radio button component and a custom checkbox, instead of Universal Selector.
-Removed "Deleted" keyword from the modified date column
-Added "Deleted" keyword to status column and background color for deleted projects. I'm not particularly attached to this change, but it's an action item in the description for this issue, so I'm including that for now.

Why did you make the changes (we will use this info to test)?

In my previous pull request, I'd created too many state/prop items and drilled them through multiple components, creating a lot of entanglement and possible points of failure. This version keeps changes limited to the popup components. It also uses radio buttons and checkboxes instead of dropdowns, keeping it closer to the prototype.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot 2024-09-07 at 12 03 06 AM
Screenshot 2024-09-07 at 12 03 10 AM
Screenshot 2024-09-07 at 12 03 03 AM

Copy link
Member

@entrotech entrotech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thank you! I had forgotten about the part about moving the deleted text to the status column and changing the background color of the deleted project rows.

@entrotech entrotech merged commit 70b753e into develop Sep 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Visibility and Status Column Filters on the My Project Page
2 participants