Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Visibility and Status Column Filters on the My Project Page #1646

Closed
5 tasks done
entrotech opened this issue Apr 2, 2024 · 10 comments · Fixed by #1831
Closed
5 tasks done

Implement the Visibility and Status Column Filters on the My Project Page #1646

entrotech opened this issue Apr 2, 2024 · 10 comments · Fixed by #1831
Assignees
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: medium p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: front-end Front End Developer size: 1pt Can be done in 4-6 hours
Milestone

Comments

@entrotech
Copy link
Member

entrotech commented Apr 2, 2024

Overview

Action Items

  • The prototype uses toggle buttons for specifying the sort order for both of these filters, but this makes no sense, since the choices should be mutually exclusive. Check with designers @yiranshan to see what they want to do.
  • Implement the filtering for the Visibility column
  • Implement the filtering for the Status column
  • Also add the word "(deleted)" to the text in the Status column cells if the project is deleted, and make the row background the same color as shown in the prototype.
  • The word "(deleted)" should no longer be appended to the Modified date.

Resources/Instructions

Refer to this Figma prototype: https://www.figma.com/proto/nD9QK56Mzq7xNSaSUoeGx0/TDM-Calculator?type=design&node-id=12173-2052&t=wQuxLI1JbOw0OzLn-1&scaling=scale-down&page-id=2499%3A11472&starting-point-node-id=11997%3A885

@entrotech entrotech added enhancement Release Note: Shows as visual or user experience Enhancement role: front-end Front End Developer level: medium priority: MUST HAVE p-feature: My Projects Page /projects size: 1pt Can be done in 4-6 hours labels Apr 2, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this to Prioritized Backlog in P: TDM: project board Jun 11, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the pbv: dev All engineering issues label Jun 11, 2024
@Jonathanko52 Jonathanko52 self-assigned this Jun 19, 2024
@Jonathanko52 Jonathanko52 moved this from Prioritized Backlog to In progress (actively working) in P: TDM: project board Jun 20, 2024
@ExperimentsInHonesty
Copy link
Member

@Jonathanko52
Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@Jonathanko52
Copy link
Member

Jonathanko52 commented Aug 9, 2024

  1. Progress:
    • Contacting Yiran for clarification regarding the issues regarding excess fields and sorting conflicts in the "visibility" and status columns".
    • Sorted out what needs to be done to implement the new design for columns, sorting, and filtering.
    • From what I'm seeing, the redesign of the new Filtering UI means it requires more than changing how the Visibility and Status columns work. It requires integrating the Filter functionality into the table itself.
  2. Blocker: None.
  3. Availability: 10 hours a week.
  4. ETA:

@Jonathanko52
Copy link
Member

Jonathanko52 commented Aug 15, 2024

  1. Create the modals.
  2. Add ability to sort by visibility/draft/snapshot.
  3. Send figma back for redesign.

@Jonathanko52
Copy link
Member

Jonathanko52 commented Aug 22, 2024

  1. Progress:
    Completed:
    1. Move the header to a separate component, using icons and colors from the new design.
      Next Steps:
    2. Create a filter dropdown for the columns.
    3. Implement functionality for said columns.
  2. Blockers: None.
  3. Availability: 5-10 hours a week.
  4. ETA: Two weeks.
  5. Pictures or links* (if necessary):
    Screenshot 2024-08-21 at 9 25 48 PM

@entrotech
Copy link
Member Author

@Jonathanko52 Since the filtering issues seemed stalled, I created an issue #1801 to lay the groundwork in code for all the colun heading filtering. Please read Issue #1801 and pull the latest develop branch. For this issue, all you will need to do is fill int he filtering logic for the VisibilityPopup and StatusPopup React components, following the example of the DatePopup.

@Jonathanko52
Copy link
Member

Screenshot 2024-08-29 at 11 11 54 PM
The visibility filter is working.

Screenshot 2024-08-29 at 11 15 15 PM
Not yet functional, but setting the status filter to now include "deleted" projects, alongside the old snapshot, draft, snapshot and draft options. Also added an 'all' option.

@Jonathanko52
Copy link
Member

Screenshot 2024-08-31 at 11 35 00 PM

Functionality for these filter options has been added.

@ExperimentsInHonesty
Copy link
Member

@Jonathanko52 I see your screenshots above, but no PR. Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@Jonathanko52
Copy link
Member

@ExperimentsInHonesty some final kinks that need to be ironed out. I'll be putting in a PR later tonight.

@Jonathanko52
Copy link
Member

  1. Progress: Making changes to pull request.
  2. Blockers: None.
  3. Availability: 1-2 hours this week.
  4. ETA: Later this week. Certainly before next Tuesday.

@github-project-automation github-project-automation bot moved this from In progress (actively working) to On Dev - not yet pushed to Prod in P: TDM: project board Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: medium p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: front-end Front End Developer size: 1pt Can be done in 4-6 hours
Projects
Status: Released
4 participants