Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design an easy option to reset the filters and sort back to default #1833

Closed
3 of 4 tasks
Tracked by #1816 ...
NilakshiS opened this issue Sep 9, 2024 · 15 comments
Closed
3 of 4 tasks
Tracked by #1816 ...

Design an easy option to reset the filters and sort back to default #1833

NilakshiS opened this issue Sep 9, 2024 · 15 comments

Comments

@NilakshiS
Copy link
Member

NilakshiS commented Sep 9, 2024

Overview

As a user I want to be able to clear all the filters and sort sections at once, so I can get back to the default view. Design a way to reset the sort and filters to default.

Details

Currently the only way to clear filters, is to open each column header. Additionally you cannot reset the sort back to default unless you know which of the sort options is the default.

Action Items

  • Compare the current designs (in figma), to see if there was something that did not get developed and needs to be sent again to dev.
  • If there is no design already, create a prototype.
  • Review with Product, Dev and Research and iterate if needed based on feedback.
  • Once finalized, get Stakeholder sign-off via the stakeholder meeting slide deck.

Resources

@NilakshiS

This comment was marked as resolved.

@thetanmancan

This comment was marked as resolved.

@thetanmancan

This comment was marked as resolved.

@NilakshiS NilakshiS moved this from Questions/Clarifications to In progress (actively working) in P: TDM: project board Oct 10, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the pbv: design all issues for design roles label Oct 10, 2024
@thetanmancan

This comment was marked as resolved.

@NilakshiS
Copy link
Member Author

NilakshiS commented Oct 15, 2024

Need feedback from product: Currently "Reset" button clears both filters and sort and there's no way to reset just the sort. Is that the desired function? Or should we create a separate button to clear sort?

Some examples of a filter overlay with different buttons to clear sort and filters

ImageImage

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Oct 16, 2024

What kind of sort do the stakeholders want

Default sort is: Sort by oldest "Created On" date first

  1. Stable sort (the way that google sheets works)
    You can sort by one column, and then by another column, and it remembers the first sort, so if the second column has values that are the same, the results within that value will be sorted by the prior sort. See image where its sorted by time first, and then sorted by day, so it shows all the Friday meetings in order of time.
  1. Column sort (the way it's working now)
    When you sort the column, no other columns remain sorted, the results of sort items that have the same name/title will be random. see image

image

@NilakshiS
Copy link
Member Author

Feedback from stakholder meeting on 10/15/24:

  • For "Clear All filters" function, text buttons next to search bar are selected.
  • A button next to search bar is usually the search button so we should keep a search button even if it's not needed so that the users do not accidentally clear all filters.
  • The button should stay on page even if no filters are selected and should be "Clear All Filters (0)".
Screenshots of button designs approved by stakeholders

image

@thetanmancan
Copy link
Member

thetanmancan commented Oct 16, 2024

Status update for @NilakshiS:

Progress: Prototypes of the possible "Clear All Filters" button were presented to stakeholders. I created three more possible variations based on what was selected during yesterday's meeting.

Three prototypes in the "My Project > Filtering (#1816-Open)" Figma page, at the bottom-right portion of the "1833" section

Screenshot 2024-10-15 211641

Blockers: We need stakeholder, developer, and product feedback about whether sort is expected to have only primary or both primary and secondary sorting functionality. See Bonnie's comment from yesterday above. This decision will impact whether or not a "Clear Sort" functionality needs to be implemented into filter overlays, as shown in the mockup below.

"clear sort order" mockup

376792768-4a46cd3f-ecc7-4150-a328-64d018848bb1

Availability: I have 15 hours this week that I can spend on TDM Calculator, whether it be for this issue or another one.

ETA: Completion time depends on feedback. If we only have primary sorting, it would only take half the week to design and implement "clear sort order" links. If we have primary and secondary sort order, we will have to come up with designs for that functionality, which will likely take the entire week and possibly also next week as we think through the implications of that decision.

@NilakshiS
Copy link
Member Author

Final Design:

  • search bar moved to left
  • clear all filters button on the right, with number of selected filters in parentheses.
Design with no filter selected

Search moved to the left, no filters selected

Design with some filters selected

Search moved to the left, filters selected

@github-project-automation github-project-automation bot moved this from Questions/Clarifications to On Dev - not yet pushed to Prod in P: TDM: project board Oct 17, 2024
@ExperimentsInHonesty
Copy link
Member

change the name of the button to Reset Filters/Sort

@github-project-automation github-project-automation bot moved this from On Dev - not yet pushed to Prod to In progress (actively working) in P: TDM: project board Oct 30, 2024
@thetanmancan
Copy link
Member

@NilakshiS

For this redesign, I removed the number after the button label because I figured it would be confusing for the user as to whether the number was a combination of sorting and filtering or was just filtering. However, we can add the number back in. Just let me know what is preferred. Thanks.

Reset Filters/Sort

Reset Filters Sort

@thetanmancan

This comment was marked as resolved.

@NilakshiS NilakshiS added the Status: Updated No blockers and update is ready for review label Nov 6, 2024
@NilakshiS

This comment was marked as resolved.

@thetanmancan

This comment was marked as resolved.

@NilakshiS
Copy link
Member Author

NilakshiS commented Nov 13, 2024

From the stakeholder meeting on 11-12-2024: Approved, "Reset Filters/Sort" is selected as the text for the button. Reasoning being there are some default filters (for eg: no deleted projects shown) and a default sort (last modified column, descending) so the numbers might be confusing (do we set it to 0 if no additional filters are selected or not?) . Final design: #1833 (comment)

@github-project-automation github-project-automation bot moved this from Questions/Clarifications to On Dev - not yet pushed to Prod in P: TDM: project board Nov 13, 2024
@NilakshiS NilakshiS removed ready for design lead Status: Updated No blockers and update is ready for review labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

3 participants