generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions and Clarification of Design for My Project Page Filtering #1816
Labels
Dependency
Issues that cannot be worked on until another issue is closed
epic
level: medium
p-feature: My Projects Page
/projects
priority: MUST HAVE
role: ui/ux design
size: 2pt
Can be done in 7-12 hours
Milestone
Comments
entrotech
added
level: medium
priority: MUST HAVE
role: ui/ux design
p-feature: My Projects Page
/projects
size: 2pt
Can be done in 7-12 hours
pbv: design
all issues for design roles
and removed
level: missing
priority: missing
labels
Sep 4, 2024
entrotech
removed
feature: missing
role: missing
milestone: missing
size: missing
labels
Sep 4, 2024
3 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ExperimentsInHonesty
moved this from New Issue Approval
to In progress (actively working)
in P: TDM: project board
Sep 6, 2024
Hi @NilakshiS these questions were raised in #1828
Also wondering if there should be a visual cue that a filter is applied on a particular column, and also if there should be a control to clear all filters. |
9 tasks
Hi @roslynwythe
As for the rest of the questions:
|
Parisajf
added
the
Dependency
Issues that cannot be worked on until another issue is closed
label
Sep 12, 2024
Parisajf
moved this from In progress (actively working)
to Ice Box
in P: TDM: project board
Sep 12, 2024
12 tasks
10 tasks
8 tasks
4 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Dependency
Issues that cannot be worked on until another issue is closed
epic
level: medium
p-feature: My Projects Page
/projects
priority: MUST HAVE
role: ui/ux design
size: 2pt
Can be done in 7-12 hours
Dependency
ready for product
andready for design lead
labelOverview
We need to review a list of potential improvements
Details
Yiran developed a re-design of the My Project Page filtering UI several months ago. We are finally getting around to implementing the design, and have several questions and suggestions about the design that need to be resolved to implement the re-design.
Action Items
Problems / Suggestions based on developer review
Details
If you have all the popups closed, there is no indication of which, if any, filters are applied and no indication of any applied sorting.
Screenshots of TDM dev
I chose this filter
And then after I applied, it was not possible to see that I had used the filter
See Google Sheets filter indicator
Details
Details
Each popup has an option to sort by that column. The prototype design uses two toggle buttons that essentially mean "Sort Ascending" or "Sort Descending" (though the labels differ based on the column). I'd argue that toggle buttons are not an appropriate choice, since it is not possible to sort ascending and descending simultaneously. A better choice is a set of two radio buttons. This allows the user to select one or the other, but not both. Moreover, the data might not be sorted by that column at all, in which case neither radio button is checked when the popup is first opened. If the user then clicks on one of the choices, it will be applied when the Apply button is clicked. They can also choose Reset to not apply sorting by that column.
Dev has already implemented this change (see My Project's page). Example
Design will need to review and indicate what changes need to be made to comply with our design system.
Details
The Primary Call to Action button on each popup is labelled "Show Result", but the usual word used for something like this is "Apply".
Details
The Visibility Popup design is pretty good. I strongly suggest removing the "Search by Keyword" control, since it is unnecessary and possibly confusing. I'd prefer to see "Visible" as the first choice, since it should be the default and the most common choice.
Screenshot from Dev for sort choices
Dev is also suggesting that these should be reordered (Visible, Hidden, Both)
Details
For the Status Popup design, we should remove the "Search by Keyword" control, since there are only 2-3 choices, so it is unnecessary and confusing. The three choices for filtering by status are "Draft", "Snapshot" or "Draft and Snapshot", which would be better represented by a set of three radio buttons with the corresponding labels. Using two checkboxes like the prototype has a problem where unchecking both boxes would filter out all projects and isn't a useful choice, so we can prevent this problem by switching to radio buttons. IMO, we should use a second set of three radio buttons for filtering by Active vs Deleted, with the choices "Active", "Deleted" or "Active and Deleted" instead of a single checkbox, because the prototype design with a single checkbox is ambiguous to users (if the box is unchecked, will you see just the deleted projects or both the active and deleted projects?).
FYI: The filtering criteria for the other columns are either for strings or date ranges and the suggested designs are good.
Changes in the "Design System"
Details
The filter icon has been changed in the style guide to MdFilterAlt. We might also need an icon to indicate that a filter is not applied to the column - Maybe MdFilterAltOff? See this page for the list of available icons.
Product thinks it should use filled and unfilled
Resources/Instructions
The text was updated successfully, but these errors were encountered: