Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design a way to see what filters have been chosen #1829

Closed
1 of 6 tasks
Tracked by #1816
NilakshiS opened this issue Sep 6, 2024 · 6 comments
Closed
1 of 6 tasks
Tracked by #1816

Design a way to see what filters have been chosen #1829

NilakshiS opened this issue Sep 6, 2024 · 6 comments

Comments

@NilakshiS
Copy link
Member

NilakshiS commented Sep 6, 2024

Overview

As a user, I want to be able to see what filters and sorting I have chosen and what filters / sorting are selected by default so I understand my results better.

Details

If you have all the popups closed, there is no indication of which, if any, filters are applied and no indication of any applied sorting.

Screenshots of TDM dev to illustrate the issue

I chose this filter

And then after I applied, it was not possible to see that I had used the filter

image

Action Items

  • Compare the current designs (in figma), to see if there was something that did not get developed and needs to be sent again to dev.
  • If there is no design already, create one and update the Figma Designs and Prototype.
  • Review with Product, Dev and Research and iterate if needed based on feedback.
  • Update the style guide to add the new design.
  • Once finalized, get Stakeholder sign-off via the stakeholder meeting slide deck.

Resources

An example of how Google Sheets indicates selected filters

image

@lbeatonn
Copy link
Member

lbeatonn commented Sep 18, 2024

I did not see a design solution for this in the Figma file so I checked the first action item " Compare the current designs (in figma), to see if there was something that did not get developed and needs to be sent again to dev."

@lbeatonn
Copy link
Member

lbeatonn commented Sep 19, 2024

Screenshot 2024-09-18 at 5 13 20 PM

Update: Iteration #1 shows the filter tags front facing, awaiting feedback from the team

@NilakshiS
Copy link
Member Author

Feedback received in the Stakeholder Prep meeting (09/19/24):

This list would get too long if multiple addresses are selected.

@lbeatonn
Copy link
Member

lbeatonn commented Sep 26, 2024

UPDATE - Sept 25th

Bonnie FEEDBACK Sept 20th - Bonnie said the list would get too long if 10 addresses are selected.

Iteration 2

States

[Short List] [Default] (3 or less filters selected)

#1829 - 09 18 2024 - Iteration #2  Short List   Default

[Long List] [Default/Collapsed]

Collapsed

[Long List] [Expanded]

#1829 - 09 18 2024 - Iteration #2  Long List   Expanded

Bonnie FEEDBACK after seeing the above Sept 25th -
make sure the view more and clear all fits well with the design system
what happens with extreme use case with 20 - 30 entries
Should you be able to hide/show all filters because you can pick so many and so many can appear???

@greenishviolet
Copy link
Member

greenishviolet commented Oct 9, 2024

10/08 Progress Update

Progress

  • I have created four variations of the side drawer where the pills will be stored
  • I created a mockup of the My Projects page with the side panel opened
  • I am playing around with how users will access the side panel. I have created different variations of the filter button and am experimenting with different places to place it.
  • I noticed that the side drawer does not fill the length of the page on the TDM Dev website. It might be a problem when more than 10 items are on the page.
Gif of TDM Dev website

Image

  • I made a prototype of a possible solution, where the side panel's position is sticky.
Gif of prototype

Image

Blockers
None at the moment

Availability
I can dedicate about 12 hours this week

ETA
I am hoping to complete this issue by next week, which might be a bit ambitious

Pictures

My Projects page with side panel

Image

Side panel variations

Image

Accessing the side panel - filter button next to the search bar

With the search button

Image

Without the search button
Image

Accessing the side panel - filter bar below tool bar

Image

@NilakshiS NilakshiS moved this from Visual Review to Questions/Clarifications in P: TDM: project board Oct 10, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the pbv: design all issues for design roles label Oct 10, 2024
@NilakshiS
Copy link
Member Author

Feedback from stakeholder meeting on 10/15: We will not have this feature this time but we'll keep these designs for future developments.

@NilakshiS NilakshiS closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Questions/Clarifications to On Dev - not yet pushed to Prod in P: TDM: project board Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

4 participants