-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#704 - updated landing page #864
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aahvocado, the landing page breaks below ~470px;
@@ -75,13 +92,12 @@ | |||
"previewing": "Previewing", | |||
"introduce_yourself": "Introduce yourself", | |||
"involvement": "Involvement", | |||
"job": "Employment", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also I think lines 78 and onward is overriding changes from dev unrelated to what you're updating here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aahvocado hey the previous changes look good but the 'complete letter' img breaks the page from 765- ~820px
last change I think!
Please test the page in mobile and desktop view sizes