Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#704 - updated landing page #864

Merged
merged 10 commits into from
Mar 6, 2023
Merged

#704 - updated landing page #864

merged 10 commits into from
Mar 6, 2023

Conversation

aahvocado
Copy link
Member

Please test the page in mobile and desktop view sizes

@aahvocado aahvocado linked an issue Feb 27, 2023 that may be closed by this pull request
25 tasks
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aahvocado, the landing page breaks below ~470px;

@@ -75,13 +92,12 @@
"previewing": "Previewing",
"introduce_yourself": "Introduce yourself",
"involvement": "Involvement",
"job": "Employment",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also I think lines 78 and onward is overriding changes from dev unrelated to what you're updating here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@aahvocado aahvocado requested a review from sydneywalcoff March 2, 2023 02:45
Copy link
Member

@sydneywalcoff sydneywalcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aahvocado hey the previous changes look good but the 'complete letter' img breaks the page from 765- ~820px

last change I think!

@sydneywalcoff sydneywalcoff merged commit e1d6b3c into dev Mar 6, 2023
@sydneywalcoff sydneywalcoff deleted the #704-landing-page-cp branch March 6, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Landing Page
2 participants